Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service

2021-11-01 Thread dexter 
dexter has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25977 )

Change subject: neighbor_ident: add comment about Neighbor Address Resolution 
Service
..

neighbor_ident: add comment about Neighbor Address Resolution Service

The Neighbor Address Resolution Service is using the control interface
API as well. Lets add a comment to indicate that this service is not
related to the normal control interface.

Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
---
M src/osmo-bsc/neighbor_ident.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c
index c66d3ac..44b0b43 100644
--- a/src/osmo-bsc/neighbor_ident.c
+++ b/src/osmo-bsc/neighbor_ident.c
@@ -489,6 +489,7 @@

 struct ctrl_handle *neighbor_controlif_setup(struct gsm_network *net)
 {
+   /* See also osmobsc-usermanual.pdf, section 14.1 Neighbor Address 
Resolution Service */
return ctrl_interface_setup_dynip2(net, net->neigh_ctrl.addr, 
net->neigh_ctrl.port,
   NULL, _LAST_CTRL_NODE_NEIGHBOR);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
Gerrit-Change-Number: 25977
Gerrit-PatchSet: 6
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service

2021-10-28 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25977 )

Change subject: neighbor_ident: add comment about Neighbor Address Resolution 
Service
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
Gerrit-Change-Number: 25977
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 28 Oct 2021 15:08:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service

2021-10-28 Thread fixeria 
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25977 )

Change subject: neighbor_ident: add comment about Neighbor Address Resolution 
Service
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
Gerrit-Change-Number: 25977
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 28 Oct 2021 11:08:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service

2021-10-27 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25977 )

Change subject: neighbor_ident: add comment about Neighbor Address Resolution 
Service
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
Gerrit-Change-Number: 25977
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 27 Oct 2021 12:54:25 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: neighbor_ident: add comment about Neighbor Address Resolution Service

2021-10-27 Thread dexter 
dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25977 )


Change subject: neighbor_ident: add comment about Neighbor Address Resolution 
Service
..

neighbor_ident: add comment about Neighbor Address Resolution Service

The Neighbor Address Resolution Service is using the control interface
API as well. Lets add a comment to indicate that this service is not
related to the normal control interface.

Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
---
M src/osmo-bsc/neighbor_ident.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/25977/1

diff --git a/src/osmo-bsc/neighbor_ident.c b/src/osmo-bsc/neighbor_ident.c
index c66d3ac..44b0b43 100644
--- a/src/osmo-bsc/neighbor_ident.c
+++ b/src/osmo-bsc/neighbor_ident.c
@@ -489,6 +489,7 @@

 struct ctrl_handle *neighbor_controlif_setup(struct gsm_network *net)
 {
+   /* See also osmobsc-usermanual.pdf, section 14.1 Neighbor Address 
Resolution Service */
return ctrl_interface_setup_dynip2(net, net->neigh_ctrl.addr, 
net->neigh_ctrl.port,
   NULL, _LAST_CTRL_NODE_NEIGHBOR);
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iec86f72548bfc54a2c86dadec69dd1c64813d852
Gerrit-Change-Number: 25977
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange