Change in osmo-bsc[master]: range_enc_determine_range(): Don't dereference array on size=0

2018-10-21 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11397 )

Change subject: range_enc_determine_range(): Don't dereference array on size=0
..

range_enc_determine_range(): Don't dereference array on size=0

Change-Id: I5bbb10af8b8e8ebc22bf79f5468e71a41b5e74b3
Fixes: Coverity CID#182710
---
M src/osmo-bsc/arfcn_range_encode.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/arfcn_range_encode.c 
b/src/osmo-bsc/arfcn_range_encode.c
index 84f9f63..54d98a9 100644
--- a/src/osmo-bsc/arfcn_range_encode.c
+++ b/src/osmo-bsc/arfcn_range_encode.c
@@ -168,6 +168,10 @@
 {
int max = 0;

+   /* don't dereference arfcns[] array if size is 0 */
+   if (size == 0)
+   return ARFCN_RANGE_128;
+
/*
 * Go for the easiest. And pick arfcns[0] == f0.
 */

--
To view, visit https://gerrit.osmocom.org/11397
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bbb10af8b8e8ebc22bf79f5468e71a41b5e74b3
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: range_enc_determine_range(): Don't dereference array on size=0

2018-10-21 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11397 )

Change subject: range_enc_determine_range(): Don't dereference array on size=0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11397
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bbb10af8b8e8ebc22bf79f5468e71a41b5e74b3
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 21 Oct 2018 11:42:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: range_enc_determine_range(): Don't dereference array on size=0

2018-10-21 Thread Harald Welte 
Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/11397


Change subject: range_enc_determine_range(): Don't dereference array on size=0
..

range_enc_determine_range(): Don't dereference array on size=0

Change-Id: I5bbb10af8b8e8ebc22bf79f5468e71a41b5e74b3
Fixes: Coverity CID#182710
---
M src/osmo-bsc/arfcn_range_encode.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/11397/1

diff --git a/src/osmo-bsc/arfcn_range_encode.c 
b/src/osmo-bsc/arfcn_range_encode.c
index 84f9f63..54d98a9 100644
--- a/src/osmo-bsc/arfcn_range_encode.c
+++ b/src/osmo-bsc/arfcn_range_encode.c
@@ -168,6 +168,10 @@
 {
int max = 0;

+   /* don't dereference arfcns[] array if size is 0 */
+   if (size == 0)
+   return ARFCN_RANGE_128;
+
/*
 * Go for the easiest. And pick arfcns[0] == f0.
 */

--
To view, visit https://gerrit.osmocom.org/11397
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bbb10af8b8e8ebc22bf79f5468e71a41b5e74b3
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte