Change in osmo-bts[master]: l1sap: radio_link_timeout(): bad_frame is a boolean

2020-08-07 Thread fixeria 
fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/19535 )

Change subject: l1sap: radio_link_timeout(): bad_frame is a boolean
..

l1sap: radio_link_timeout(): bad_frame is a boolean

Change-Id: Id173f69705948aafe861ec36450b147deda95246
---
M src/common/l1sap.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index ea1219f..eac5000 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1168,7 +1168,7 @@
 /* process radio link timeout counter S. Follows TS 05.08 Section 5.2
  * "MS Procedure" as the "BSS Procedure [...] shall be determined by the
  * network operator." */
-static void radio_link_timeout(struct gsm_lchan *lchan, int bad_frame)
+static void radio_link_timeout(struct gsm_lchan *lchan, bool bad_frame)
 {
struct gsm_bts *bts = lchan->ts->trx->bts;

@@ -1332,7 +1332,7 @@
le = >lapdm_ch.lapdm_acch;
rsl_tx_meas_res(lchan, NULL, 0, le);

-   radio_link_timeout(lchan, 1);
+   radio_link_timeout(lchan, true);
lchan_ms_pwr_ctrl(lchan, lchan->ms_power_ctrl.current, 
data_ind->rssi);
}
return -EINVAL;
@@ -1343,7 +1343,7 @@
handover_frame(lchan);

if (L1SAP_IS_LINK_SACCH(link_id)) {
-   radio_link_timeout(lchan, 0);
+   radio_link_timeout(lchan, false);
le = >lapdm_ch.lapdm_acch;
/* save the SACCH L1 header in the lchan struct for RSL MEAS 
RES */
if (len < 2) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id173f69705948aafe861ec36450b147deda95246
Gerrit-Change-Number: 19535
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-bts[master]: l1sap: radio_link_timeout(): bad_frame is a boolean

2020-08-07 Thread fixeria 
Hello laforge, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/19535

to look at the new patch set (#3).

Change subject: l1sap: radio_link_timeout(): bad_frame is a boolean
..

l1sap: radio_link_timeout(): bad_frame is a boolean

Change-Id: Id173f69705948aafe861ec36450b147deda95246
---
M src/common/l1sap.c
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/35/19535/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id173f69705948aafe861ec36450b147deda95246
Gerrit-Change-Number: 19535
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: l1sap: radio_link_timeout(): bad_frame is a boolean

2020-08-06 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/19535 )

Change subject: l1sap: radio_link_timeout(): bad_frame is a boolean
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id173f69705948aafe861ec36450b147deda95246
Gerrit-Change-Number: 19535
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:40 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: l1sap: radio_link_timeout(): bad_frame is a boolean

2020-08-05 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/19535 )


Change subject: l1sap: radio_link_timeout(): bad_frame is a boolean
..

l1sap: radio_link_timeout(): bad_frame is a boolean

Change-Id: Id173f69705948aafe861ec36450b147deda95246
---
M src/common/l1sap.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/35/19535/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index ea1219f..eac5000 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1168,7 +1168,7 @@
 /* process radio link timeout counter S. Follows TS 05.08 Section 5.2
  * "MS Procedure" as the "BSS Procedure [...] shall be determined by the
  * network operator." */
-static void radio_link_timeout(struct gsm_lchan *lchan, int bad_frame)
+static void radio_link_timeout(struct gsm_lchan *lchan, bool bad_frame)
 {
struct gsm_bts *bts = lchan->ts->trx->bts;

@@ -1332,7 +1332,7 @@
le = >lapdm_ch.lapdm_acch;
rsl_tx_meas_res(lchan, NULL, 0, le);

-   radio_link_timeout(lchan, 1);
+   radio_link_timeout(lchan, true);
lchan_ms_pwr_ctrl(lchan, lchan->ms_power_ctrl.current, 
data_ind->rssi);
}
return -EINVAL;
@@ -1343,7 +1343,7 @@
handover_frame(lchan);

if (L1SAP_IS_LINK_SACCH(link_id)) {
-   radio_link_timeout(lchan, 0);
+   radio_link_timeout(lchan, false);
le = >lapdm_ch.lapdm_acch;
/* save the SACCH L1 header in the lchan struct for RSL MEAS 
RES */
if (len < 2) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id173f69705948aafe861ec36450b147deda95246
Gerrit-Change-Number: 19535
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange