Change in osmo-bts[master]: l1sap: radio_link_timeout(): use LOGPLCHAN() macro

2020-08-07 Thread fixeria 
fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/19534 )

Change subject: l1sap: radio_link_timeout(): use LOGPLCHAN() macro
..

l1sap: radio_link_timeout(): use LOGPLCHAN() macro

Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
---
M src/common/l1sap.c
1 file changed, 8 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index dc236aa..ea1219f 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1178,14 +1178,15 @@

/* if link loss criterion already reached */
if (lchan->s == 0) {
-   DEBUGP(DMEAS, "%s radio link timeout counter S is already 0\n",
-   gsm_lchan_name(lchan));
+   LOGPLCHAN(lchan, DMEAS, LOGL_DEBUG,
+ "radio link timeout counter S is already 0\n");
return;
}

if (bad_frame) {
-   DEBUGP(DMEAS, "%s decreasing radio link timeout counter S=%d -> 
%d\n",
-   gsm_lchan_name(lchan), lchan->s, lchan->s - 1);
+   LOGPLCHAN(lchan, DMEAS, LOGL_DEBUG,
+ "decreasing radio link timeout counter S=%d -> %d\n",
+ lchan->s, lchan->s - 1);
lchan->s--; /* count down radio link counter S */
if (lchan->s == 0) {
LOGPLCHAN(lchan, DMEAS, LOGL_NOTICE,
@@ -1201,8 +1202,9 @@
int s = lchan->s + 2;
if (s > bts->radio_link_timeout)
s = bts->radio_link_timeout;
-   DEBUGP(DMEAS, "%s increasing radio link timeout counter S=%d -> 
%d\n",
-   gsm_lchan_name(lchan), lchan->s, s);
+   LOGPLCHAN(lchan, DMEAS, LOGL_DEBUG,
+ "increasing radio link timeout counter S=%d -> %d\n",
+ lchan->s, s);
lchan->s = s;
}
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
Gerrit-Change-Number: 19534
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-bts[master]: l1sap: radio_link_timeout(): use LOGPLCHAN() macro

2020-08-07 Thread fixeria 
Hello laforge, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/19534

to look at the new patch set (#3).

Change subject: l1sap: radio_link_timeout(): use LOGPLCHAN() macro
..

l1sap: radio_link_timeout(): use LOGPLCHAN() macro

Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
---
M src/common/l1sap.c
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/19534/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
Gerrit-Change-Number: 19534
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: l1sap: radio_link_timeout(): use LOGPLCHAN() macro

2020-08-06 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/19534 )

Change subject: l1sap: radio_link_timeout(): use LOGPLCHAN() macro
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
Gerrit-Change-Number: 19534
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Thu, 06 Aug 2020 15:53:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: l1sap: radio_link_timeout(): use LOGPLCHAN() macro

2020-08-05 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/19534 )


Change subject: l1sap: radio_link_timeout(): use LOGPLCHAN() macro
..

l1sap: radio_link_timeout(): use LOGPLCHAN() macro

Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
---
M src/common/l1sap.c
1 file changed, 8 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/19534/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index dc236aa..ea1219f 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1178,14 +1178,15 @@

/* if link loss criterion already reached */
if (lchan->s == 0) {
-   DEBUGP(DMEAS, "%s radio link timeout counter S is already 0\n",
-   gsm_lchan_name(lchan));
+   LOGPLCHAN(lchan, DMEAS, LOGL_DEBUG,
+ "radio link timeout counter S is already 0\n");
return;
}

if (bad_frame) {
-   DEBUGP(DMEAS, "%s decreasing radio link timeout counter S=%d -> 
%d\n",
-   gsm_lchan_name(lchan), lchan->s, lchan->s - 1);
+   LOGPLCHAN(lchan, DMEAS, LOGL_DEBUG,
+ "decreasing radio link timeout counter S=%d -> %d\n",
+ lchan->s, lchan->s - 1);
lchan->s--; /* count down radio link counter S */
if (lchan->s == 0) {
LOGPLCHAN(lchan, DMEAS, LOGL_NOTICE,
@@ -1201,8 +1202,9 @@
int s = lchan->s + 2;
if (s > bts->radio_link_timeout)
s = bts->radio_link_timeout;
-   DEBUGP(DMEAS, "%s increasing radio link timeout counter S=%d -> 
%d\n",
-   gsm_lchan_name(lchan), lchan->s, s);
+   LOGPLCHAN(lchan, DMEAS, LOGL_DEBUG,
+ "increasing radio link timeout counter S=%d -> %d\n",
+ lchan->s, s);
lchan->s = s;
}
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icc642599d85a751a750b382674dea5614b6f9ee4
Gerrit-Change-Number: 19534
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange