Change in osmo-ci[master]: ansible: Fix several file permission mask format

2019-11-27 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )

Change subject: ansible: Fix several file permission mask format
..

ansible: Fix several file permission mask format

>From ansible documentation [1]:
"""
For those used to /usr/bin/chmod remember that modes are actually octal
numbers. You must either add a leading zero so that Ansible's YAML
parser knows it is an octal number (like 0644 or 01777) or quote it
(like '644' or '1777') so Ansible receives a string and can do its own
conversion from string into number.
Giving Ansible a number without following one of these rules will end up
with a decimal number which will have unexpected results.
"""

[1] 
https://docs.ansible.com/ansible/latest/modules/template_module.html?highlight=template

Change-Id: I91008927c50016a837420c4249b5f69b9153572e
---
M ansible/roles/gsm-tester/tasks/main.yml
M ansible/roles/install-coverity/tasks/main.yml
M ansible/roles/install-poky-sdk/tasks/main.yml
3 files changed, 7 insertions(+), 9 deletions(-)

Approvals:
  pespin: Verified
  lynxis lazus: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/ansible/roles/gsm-tester/tasks/main.yml 
b/ansible/roles/gsm-tester/tasks/main.yml
index 34846a5..d880127 100644
--- a/ansible/roles/gsm-tester/tasks/main.yml
+++ b/ansible/roles/gsm-tester/tasks/main.yml
@@ -191,7 +191,7 @@
   file:
 path: /usr/sbin/tcpdump
 group: osmo-gsm-tester
-mode: 750
+mode: 0750

 - name: create a symlink for tcpdump
   file:
@@ -219,7 +219,7 @@
   copy:
 src: osmo-gsm-tester_setcap_net_raw.sh
 dest: /usr/local/bin/osmo-gsm-tester_setcap_net_raw.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_raw.sh
   copy:
@@ -232,7 +232,7 @@
   copy:
 src: osmo-gsm-tester_setcap_net_admin.sh
 dest: /usr/local/bin/osmo-gsm-tester_setcap_net_admin.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_admin.sh
   copy:
@@ -245,7 +245,7 @@
   copy:
 src: osmo-gsm-tester_netns_exec.sh
 dest: /usr/local/bin/osmo-gsm-tester_netns_exec.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_exec.sh
   copy:
@@ -258,7 +258,7 @@
   copy:
 src: osmo-gsm-tester_netns_setup.sh
 dest: /usr/local/bin/osmo-gsm-tester_netns_setup.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_setup.sh
   copy:
diff --git a/ansible/roles/install-coverity/tasks/main.yml 
b/ansible/roles/install-coverity/tasks/main.yml
index 200a349..886dda2 100644
--- a/ansible/roles/install-coverity/tasks/main.yml
+++ b/ansible/roles/install-coverity/tasks/main.yml
@@ -3,7 +3,7 @@
   copy:
 src: "{{ coverity_installer_file }}"
 dest: "/tmp/{{ coverity_installer_file }}"
-mode: 750
+mode: 0750
   register: coverity_copy
   ignore_errors: yes
   tags: [coverity]
@@ -36,4 +36,3 @@
 msg: "Ansible can not find {{ coverity_installer_file }}"
   when: coverity_copy.failed
   tags: [coverity]
-
diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml 
b/ansible/roles/install-poky-sdk/tasks/main.yml
index 85b310a..7f95dce 100644
--- a/ansible/roles/install-poky-sdk/tasks/main.yml
+++ b/ansible/roles/install-poky-sdk/tasks/main.yml
@@ -12,7 +12,7 @@
   copy:
 src: "{{ poky_installer_file }}"
 dest: "/tmp/{{ poky_installer_file }}"
-mode: 750
+mode: 0750
   register: poky_copy
   ignore_errors: yes
   tags: [poky]
@@ -45,4 +45,3 @@
 msg: "Ansible can not find or copy {{ poky_installer_file }}"
   when: poky_copy.failed
   tags: [poky]
-

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/16234
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I91008927c50016a837420c4249b5f69b9153572e
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ci[master]: ansible: Fix several file permission mask format

2019-11-27 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )

Change subject: ansible: Fix several file permission mask format
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/16234
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I91008927c50016a837420c4249b5f69b9153572e
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:42:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: ansible: Fix several file permission mask format

2019-11-26 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )

Change subject: ansible: Fix several file permission mask format
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/16234
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I91008927c50016a837420c4249b5f69b9153572e
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 27 Nov 2019 00:18:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: ansible: Fix several file permission mask format

2019-11-26 Thread lynxis lazus 
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )

Change subject: ansible: Fix several file permission mask format
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/16234
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I91008927c50016a837420c4249b5f69b9153572e
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 26 Nov 2019 18:21:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: ansible: Fix several file permission mask format

2019-11-26 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )


Change subject: ansible: Fix several file permission mask format
..

ansible: Fix several file permission mask format

>From ansible documentation [1]:
"""
For those used to /usr/bin/chmod remember that modes are actually octal
numbers. You must either add a leading zero so that Ansible's YAML
parser knows it is an octal number (like 0644 or 01777) or quote it
(like '644' or '1777') so Ansible receives a string and can do its own
conversion from string into number.
Giving Ansible a number without following one of these rules will end up
with a decimal number which will have unexpected results.
"""

[1] 
https://docs.ansible.com/ansible/latest/modules/template_module.html?highlight=template

Change-Id: I91008927c50016a837420c4249b5f69b9153572e
---
M ansible/roles/gsm-tester/tasks/main.yml
M ansible/roles/install-coverity/tasks/main.yml
M ansible/roles/install-poky-sdk/tasks/main.yml
3 files changed, 7 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/16234/1

diff --git a/ansible/roles/gsm-tester/tasks/main.yml 
b/ansible/roles/gsm-tester/tasks/main.yml
index 34846a5..d880127 100644
--- a/ansible/roles/gsm-tester/tasks/main.yml
+++ b/ansible/roles/gsm-tester/tasks/main.yml
@@ -191,7 +191,7 @@
   file:
 path: /usr/sbin/tcpdump
 group: osmo-gsm-tester
-mode: 750
+mode: 0750

 - name: create a symlink for tcpdump
   file:
@@ -219,7 +219,7 @@
   copy:
 src: osmo-gsm-tester_setcap_net_raw.sh
 dest: /usr/local/bin/osmo-gsm-tester_setcap_net_raw.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_raw.sh
   copy:
@@ -232,7 +232,7 @@
   copy:
 src: osmo-gsm-tester_setcap_net_admin.sh
 dest: /usr/local/bin/osmo-gsm-tester_setcap_net_admin.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_setcap_net_admin.sh
   copy:
@@ -245,7 +245,7 @@
   copy:
 src: osmo-gsm-tester_netns_exec.sh
 dest: /usr/local/bin/osmo-gsm-tester_netns_exec.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_exec.sh
   copy:
@@ -258,7 +258,7 @@
   copy:
 src: osmo-gsm-tester_netns_setup.sh
 dest: /usr/local/bin/osmo-gsm-tester_netns_setup.sh
-mode: 755
+mode: 0755

 - name: allow osmo-gsm-tester sudo osmo-gsm-tester_netns_setup.sh
   copy:
diff --git a/ansible/roles/install-coverity/tasks/main.yml 
b/ansible/roles/install-coverity/tasks/main.yml
index 200a349..886dda2 100644
--- a/ansible/roles/install-coverity/tasks/main.yml
+++ b/ansible/roles/install-coverity/tasks/main.yml
@@ -3,7 +3,7 @@
   copy:
 src: "{{ coverity_installer_file }}"
 dest: "/tmp/{{ coverity_installer_file }}"
-mode: 750
+mode: 0750
   register: coverity_copy
   ignore_errors: yes
   tags: [coverity]
@@ -36,4 +36,3 @@
 msg: "Ansible can not find {{ coverity_installer_file }}"
   when: coverity_copy.failed
   tags: [coverity]
-
diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml 
b/ansible/roles/install-poky-sdk/tasks/main.yml
index 85b310a..7f95dce 100644
--- a/ansible/roles/install-poky-sdk/tasks/main.yml
+++ b/ansible/roles/install-poky-sdk/tasks/main.yml
@@ -12,7 +12,7 @@
   copy:
 src: "{{ poky_installer_file }}"
 dest: "/tmp/{{ poky_installer_file }}"
-mode: 750
+mode: 0750
   register: poky_copy
   ignore_errors: yes
   tags: [poky]
@@ -45,4 +45,3 @@
 msg: "Ansible can not find or copy {{ poky_installer_file }}"
   when: poky_copy.failed
   tags: [poky]
-

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/16234
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I91008927c50016a837420c4249b5f69b9153572e
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange