Change in osmo-ci[master]: coverity: don't install systemd file

2018-09-19 Thread lynxis lazus 
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/11017 )

Change subject: coverity: don't install systemd file
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
Gerrit-Change-Number: 11017
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Wed, 19 Sep 2018 09:57:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: coverity: don't install systemd file

2018-09-19 Thread lynxis lazus 
lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11017 )

Change subject: coverity: don't install systemd file
..

coverity: don't install systemd file

Because the systemd install directory does not use --prefix as
base, they are installed by default to /lib/systemd.
As the coverity only scans the compilation, don't install systemd files.

Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
---
M coverity/build_Osmocom.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh
index 920c0b9..86bb569 100755
--- a/coverity/build_Osmocom.sh
+++ b/coverity/build_Osmocom.sh
@@ -12,7 +12,7 @@

 do_build() {
autoreconf --install --force
-   ./configure --prefix="$prefix" $*
+   ./configure --prefix="$prefix" --with-systemdsystemunitdir=no $*

make $PARALLEL_MAKE
make install

--
To view, visit https://gerrit.osmocom.org/11017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
Gerrit-Change-Number: 11017
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus

Change in osmo-ci[master]: coverity: don't install systemd file

2018-09-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11017 )

Change subject: coverity: don't install systemd file
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
Gerrit-Change-Number: 11017
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Wed, 19 Sep 2018 09:51:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: coverity: don't install systemd file

2018-09-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11017 )

Change subject: coverity: don't install systemd file
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
Gerrit-Change-Number: 11017
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Wed, 19 Sep 2018 08:15:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: coverity: don't install systemd file

2018-09-18 Thread lynxis lazus 
Hello Pau Espin Pedrol,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11017

to look at the new patch set (#2).

Change subject: coverity: don't install systemd file
..

coverity: don't install systemd file

Because the systemd install directory does not use --prefix as
base, they are installed by default to /lib/systemd.
As the coverity only scans the compilation, don't install systemd files.

Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
---
M coverity/build_Osmocom.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/11017/2
--
To view, visit https://gerrit.osmocom.org/11017
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39b491fc09f0db0efd8d9d09e8f4cba4ba49cdde
Gerrit-Change-Number: 11017
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus