Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11741 )

Change subject: gitignore: add make/ and net/ (with exceptions)
..

gitignore: add make/ and net/ (with exceptions)

Ignore all files and folders that get created when following the README
and net/README instructions.

Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
---
M .gitignore
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved; Verified



diff --git a/.gitignore b/.gitignore
index c09c878..b6d7fe7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,8 +3,15 @@
 tags
 *.pyc
 make-*
+make/*
 src/*
 !src/fetch-gerrit-patch.sh
 !src/gits
 !src/osmo-add-gerrit-hooks.sh
 !src/README
+net/*
+!net/tmpl_*
+!net/config_2g3g
+!net/common_*
+!net/README
+!net/fill_config.py

--
To view, visit https://gerrit.osmocom.org/11741
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
Gerrit-Change-Number: 11741
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 


Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11741 )

Change subject: gitignore: add make/ and net/ (with exceptions)
..


Patch Set 2: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11741
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
Gerrit-Change-Number: 11741
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 20 Nov 2018 01:41:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11741 )

Change subject: gitignore: add make/ and net/ (with exceptions)
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11741/1/.gitignore
File .gitignore:

https://gerrit.osmocom.org/#/c/11741/1/.gitignore@6
PS1, Line 6: make/
> (should this be 'make/*' ? I'm not sure... […]
I couldn't find and advantage either way, but I changed it to make/* to have it 
consistent with src/* and net/*.


https://gerrit.osmocom.org/#/c/11741/1/.gitignore@8
PS1, Line 8: !src/g
> ah we should drop these since 'gits' is here instead
oh, right! removed here:
https://gerrit.osmocom.org/#/c/osmo-dev/+/11759



--
To view, visit https://gerrit.osmocom.org/11741
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
Gerrit-Change-Number: 11741
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 13 Nov 2018 10:49:53 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No


Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-13 Thread osmith
Hello Neels Hofmeyr,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11741

to look at the new patch set (#2).

Change subject: gitignore: add make/ and net/ (with exceptions)
..

gitignore: add make/ and net/ (with exceptions)

Ignore all files and folders that get created when following the README
and net/README instructions.

Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
---
M .gitignore
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/41/11741/2
--
To view, visit https://gerrit.osmocom.org/11741
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
Gerrit-Change-Number: 11741
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 


Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11741 )

Change subject: gitignore: add make/ and net/ (with exceptions)
..


Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/11741/1/.gitignore
File .gitignore:

https://gerrit.osmocom.org/#/c/11741/1/.gitignore@6
PS1, Line 6: make/
(should this be 'make/*' ? I'm not sure...)


https://gerrit.osmocom.org/#/c/11741/1/.gitignore@8
PS1, Line 8: !src/g
ah we should drop these since 'gits' is here instead



--
To view, visit https://gerrit.osmocom.org/11741
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
Gerrit-Change-Number: 11741
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 12 Nov 2018 17:46:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes


Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11741


Change subject: gitignore: add make/ and net/ (with exceptions)
..

gitignore: add make/ and net/ (with exceptions)

Ignore all files and folders that get created when following the README
and net/README instructions.

Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
---
M .gitignore
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/41/11741/1

diff --git a/.gitignore b/.gitignore
index 1f4e0d8..42ba1db 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,9 +3,16 @@
 tags
 *.pyc
 make-*
+make/
 src/*
 !src/g
 !src/e
 !src/st
 !src/s
 !src/README
+net/*
+!net/tmpl_*
+!net/config_2g3g
+!net/common_*
+!net/README
+!net/fill_config.py

--
To view, visit https://gerrit.osmocom.org/11741
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62277f973cc8f1ee61c5244c9d8cc75775c7cfd9
Gerrit-Change-Number: 11741
Gerrit-PatchSet: 1
Gerrit-Owner: osmith