Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-24 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..

common: extend glossary.adoc

Add EIR, IMEISV, LU, SS, TS, USSD, and VLR, clarify the difference
between IMEI and IMEISV.

Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
---
M common/chapters/glossary.adoc
1 file changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/common/chapters/glossary.adoc b/common/chapters/glossary.adoc
index 74973b3..e8fed3c 100644
--- a/common/chapters/glossary.adoc
+++ b/common/chapters/glossary.adoc
@@ -85,6 +85,9 @@
   GPRS; introduces 8PSK
 EGPRS::
   Enhanced GPRS; the part of EDGE relating to GPRS services
+EIR::
+  Equipment Identity Register; core network element that stores and manages
+  IMEI numbers
 ESME::
   External SMS Entity; an external application interfacing with a SMSC
   over SMPP
@@ -128,7 +131,11 @@
 IE::
   Information Element
 IMEI::
-  International Mobile Equipment Identity; unique identifier for the mobile 
phone
+  International Mobile Equipment Identity; unique 14-digit decimal number to
+  globally identify a mobile device, optionally with a 15th checksum digit
+IMEISV::
+  IMEI software version; unique 14-digit decimal number to globally identify a
+  mobile device (same as IMEI) plus two software version digits (total digits: 
16)
 IMSI::
   International Mobile Subscriber Identity; 15-digit unique identifier
   for the subscriber/SIM; starts with MCC/MNC of issuing operator
@@ -147,6 +154,9 @@
   44.064_ <<3gpp-ts-44-064>>)
 Location Area::
   Location Area; a geographic area containing multiple BTS
+LU::
+  Location Updating; can be of type IMSI-Attach or Periodic. Procedure that
+  indicates a subscriber's physical presence in a given radio cell.
 M2PA::
   MTP2 Peer-to-Peer Adaptation; a SIGTRAN Variant (_RFC 4165_ <>)
 M2UA::
@@ -284,6 +294,10 @@
   Short Message Service Center; store-and-forward relay for short messages
 SS7::
   Signaling System No. 7; Classic digital telephony signaling system
+SS::
+  Supplementary Services; query and set various service parameters between
+  subscriber and core network (e.g. USSD, 3rd-party calls, hold/retrieve,
+  advice-of-charge, call deflection)
 SSH::
   Secure Shell; _IETF RFC 4250_ <> to 4254
 SSN::
@@ -306,6 +320,8 @@
   Trivial File Transfer Protocol; (_IETF RFC 1350_ <>)
 TRX::
   Transceiver; element of a BTS serving a single carrier
+TS::
+  Technical Specification
 u-Boot::
   Boot loader used in various embedded systems
 UBI::
@@ -324,10 +340,16 @@
 USIM::
   Universal Subscriber Identity Module; application running on a UICC
   to provide subscriber identity for UMTS and GSM networks
+USSD::
+  Unstructured Supplementary Service Data; textual dialog between subscriber
+  and core network, e.g. '*#100#' -> 'Your extension is 1234'
 VCTCXO::
   Voltage Controlled, Temperature Compensated Crystal Oscillator;  a
   precision oscillator, superior to a classic crystal oscillator, but
   inferior to an OCXO
+VLR::
+  Visitor Location Register; volatile storage of attached subscribers in
+  the MSC
 VPLMN::
   Visited PLMN; the network in which the subscriber is currently
   registered; may differ from HPLMN when on roaming

--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-24 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 24 Jan 2019 18:23:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-21 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12567/2/common/chapters/glossary.adoc
File common/chapters/glossary.adoc:

https://gerrit.osmocom.org/#/c/12567/2/common/chapters/glossary.adoc@298
PS2, Line 298: Supplementary Services; query and set various service parameters 
between
 :   subscriber and core network (e.g. USSD, 3rd-party
> Updated the description of SS and added USSD.
oh, out of my depth, not really aware of SS vs USSD



--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 21 Jan 2019 14:35:19 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-21 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12567/2/common/chapters/glossary.adoc
File common/chapters/glossary.adoc:

https://gerrit.osmocom.org/#/c/12567/2/common/chapters/glossary.adoc@298
PS2, Line 298: Supplementary Services; textual dialog between subscriber and 
core
 :   network, e.g. '*#100#' -> 'Your extension is 1234'
> actually, your example is USSD, which is only one part of non-call-related 
> SS, which again are only  […]
Updated the description of SS and added USSD.



--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 21 Jan 2019 14:12:06 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-21 Thread osmith
Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12567

to look at the new patch set (#3).

Change subject: common: extend glossary.adoc
..

common: extend glossary.adoc

Add EIR, IMEISV, LU, SS, TS, USSD, and VLR, clarify the difference
between IMEI and IMEISV.

Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
---
M common/chapters/glossary.adoc
1 file changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/67/12567/3
--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12567/2/common/chapters/glossary.adoc
File common/chapters/glossary.adoc:

https://gerrit.osmocom.org/#/c/12567/2/common/chapters/glossary.adoc@298
PS2, Line 298: Supplementary Services; textual dialog between subscriber and 
core
 :   network, e.g. '*#100#' -> 'Your extension is 1234'
actually, your example is USSD, which is only one part of non-call-related SS, 
which again are only a part of SS. Supplementary services are also used for 
3-party calls, hold/retrieve, advice-of-charge, call deflection, ...



--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 17 Jan 2019 12:31:17 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-17 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 1:

(2 comments)

Updated.

https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc
File common/chapters/glossary.adoc:

https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@89
PS1, Line 89:   Equipment Identity Register
> "Core network element that stores and manages IMEI numbers"? (does it do 
> something else?)
That sounds accurate.

https://en.wikipedia.org/wiki/Network_switching_subsystem#Equipment_identity_register_(EIR)


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@244
PS1, Line 244:   Proxy Visitor Location Register
> first time I hear of that, what does it do?
I found it in osmo-msc.git/src/libvlr/vlr_lu_fsm.c; it is not spelled out or 
described there, and git blame points to the big "Add libvlr implementation" 
commit with no further description of what PVLR is.

With online research I figured, that it probably means Proxy Visitor Location 
Register. But researching further, it seems to be "Previous VLR" as noted in 
Figure 4.1.2.7 (sheet 1 of 1): Process Send_Identification_PVLR of TS 23.012.

I'll remove this from the patch.



--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 17 Jan 2019 09:46:24 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-17 Thread osmith
Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12567

to look at the new patch set (#2).

Change subject: common: extend glossary.adoc
..

common: extend glossary.adoc

Add EIR, IMEISV, LU, SS, TS and VLR, clarify the difference between
IMEI and IMEISV.

Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
---
M common/chapters/glossary.adoc
1 file changed, 19 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/67/12567/2
--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-16 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12567 )

Change subject: common: extend glossary.adoc
..


Patch Set 1: Code-Review+1

(8 comments)

potential additions...

https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc
File common/chapters/glossary.adoc:

https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@89
PS1, Line 89:   Equipment Identity Register
"Core network element that stores and manages IMEI numbers"? (does it do 
something else?)


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@133
PS1, Line 133:   International Mobile Equipment Identity; 14-digit unique 
identifier for the mobile phone plus a check digit (total digits: 15)
- Mention "decimal" somehow?
- modems also have IMEIs
maybe "unique 14-digit decimal number to globally identify a mobile device"?

To me it feels like "check digit" is a bit of a weird name. "checksum digit"?

>From the recent osmo-hlr patches I remember that we're not always handling the 
>IMEI in 15 digits, maybe "optionally with a 15th checksum digit"?


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@135
PS1, Line 135:   IMEI software version; 14-digit unique identifier for the 
mobile phone plus two software version digits (total digits: 16)
(same)


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@155
PS1, Line 155:   Location Update
in the specs usually "Location Updating"

maybe add "Can be of type IMSI-Attach or Periodic. Procedure that indicates a 
subscriber's physical presence in a given radio cell."


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@244
PS1, Line 244:   Proxy Visitor Location Register
first time I hear of that, what does it do?


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@296
PS1, Line 296:   Supplementary Services
maybe add "textual dialog between subscriber and core network, e.g. '*#100#' -> 
'Your extension is 1234'"


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@320
PS1, Line 320:   Technical Specification
heh


https://gerrit.osmocom.org/#/c/12567/1/common/chapters/glossary.adoc@344
PS1, Line 344:   Visitor Location Register
"Volatile storage of attached subscribers in the MSC"



--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:24:52 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes


Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-15 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12567


Change subject: common: extend glossary.adoc
..

common: extend glossary.adoc

Add EIR, IMEISV, LU, PVLR, SS, TS and VLR, clarify the difference
between IMEI and IMEISV.

Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
---
M common/chapters/glossary.adoc
1 file changed, 15 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/67/12567/1

diff --git a/common/chapters/glossary.adoc b/common/chapters/glossary.adoc
index 74973b3..dd6a76f 100644
--- a/common/chapters/glossary.adoc
+++ b/common/chapters/glossary.adoc
@@ -85,6 +85,8 @@
   GPRS; introduces 8PSK
 EGPRS::
   Enhanced GPRS; the part of EDGE relating to GPRS services
+EIR::
+  Equipment Identity Register
 ESME::
   External SMS Entity; an external application interfacing with a SMSC
   over SMPP
@@ -128,7 +130,9 @@
 IE::
   Information Element
 IMEI::
-  International Mobile Equipment Identity; unique identifier for the mobile 
phone
+  International Mobile Equipment Identity; 14-digit unique identifier for the 
mobile phone plus a check digit (total digits: 15)
+IMEISV::
+  IMEI software version; 14-digit unique identifier for the mobile phone plus 
two software version digits (total digits: 16)
 IMSI::
   International Mobile Subscriber Identity; 15-digit unique identifier
   for the subscriber/SIM; starts with MCC/MNC of issuing operator
@@ -147,6 +151,8 @@
   44.064_ <<3gpp-ts-44-064>>)
 Location Area::
   Location Area; a geographic area containing multiple BTS
+LU::
+  Location Update
 M2PA::
   MTP2 Peer-to-Peer Adaptation; a SIGTRAN Variant (_RFC 4165_ <>)
 M2UA::
@@ -234,6 +240,8 @@
 PUK::
   PIN Unblocking Code; used to unblock a blocked PIN (after too many
   wrong PIN attempts)
+PVLR::
+  Proxy Visitor Location Register
 RAC::
   Routing Area Code; 16bit identifier for a Routing Area within a Location Area
 RACH::
@@ -284,6 +292,8 @@
   Short Message Service Center; store-and-forward relay for short messages
 SS7::
   Signaling System No. 7; Classic digital telephony signaling system
+SS::
+  Supplementary Services
 SSH::
   Secure Shell; _IETF RFC 4250_ <> to 4254
 SSN::
@@ -306,6 +316,8 @@
   Trivial File Transfer Protocol; (_IETF RFC 1350_ <>)
 TRX::
   Transceiver; element of a BTS serving a single carrier
+TS::
+  Technical Specification
 u-Boot::
   Boot loader used in various embedded systems
 UBI::
@@ -328,6 +340,8 @@
   Voltage Controlled, Temperature Compensated Crystal Oscillator;  a
   precision oscillator, superior to a classic crystal oscillator, but
   inferior to an OCXO
+VLR::
+  Visitor Location Register
 VPLMN::
   Visited PLMN; the network in which the subscriber is currently
   registered; may differ from HPLMN when on roaming

--
To view, visit https://gerrit.osmocom.org/12567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I054a8599a78eb5e62ab7af914875e1c8a992af71
Gerrit-Change-Number: 12567
Gerrit-PatchSet: 1
Gerrit-Owner: osmith