Change in osmo-gsm-tester[master]: defaults.conf: Set valid default codec_list matching avail TS types

2018-10-30 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11502 )

Change subject: defaults.conf: Set valid default codec_list matching avail TS 
types
..

defaults.conf: Set valid default codec_list matching avail TS types

By default, all channels are TCH/F, and as a result we cannot run half
rate codecs on it.

Since recent versions of osmo-bsc, it checks this kind of
misconfigurations and answers with an Assignment Failure:

20181029162133430 DMSC <0007> codec_pref.c:445 codec-support/trx config of BTS 
0 does not intersect with codec-list of MSC 0
20181029162133430 DMSC <0007> osmo_bsc_main.c:887 Configuration contains 
mutually exclusive codec settings -- check configuration!

20181029162255253 DMSC <0007> osmo_bsc_bssap.c:859 Rx MSC DT1 BSSMAP ASSIGNMENT 
REQ
20181029162255254 DMSC <0007> osmo_bsc_bssap.c:718 No supported audio type 
found for channel_type = { ch_indctr=0x1, ch_rate_type=0xa, perm_spch=[ 42 21 
11 01 25 05 ]

Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
---
M example/defaults.conf
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  dexter: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/example/defaults.conf b/example/defaults.conf
index dc38030..1855883 100644
--- a/example/defaults.conf
+++ b/example/defaults.conf
@@ -15,7 +15,7 @@
 long_name: osmo-gsm-tester-msc
 encryption: a5_0
 codec_list:
-- hr3
+- fr1

 msc:
   net:

--
To view, visit https://gerrit.osmocom.org/11502
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
Gerrit-Change-Number: 11502
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter

Change in osmo-gsm-tester[master]: defaults.conf: Set valid default codec_list matching avail TS types

2018-10-30 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11502 )

Change subject: defaults.conf: Set valid default codec_list matching avail TS 
types
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11502
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
Gerrit-Change-Number: 11502
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Tue, 30 Oct 2018 14:54:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: defaults.conf: Set valid default codec_list matching avail TS types

2018-10-29 Thread dexter 
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11502 )

Change subject: defaults.conf: Set valid default codec_list matching avail TS 
types
..


Patch Set 1: Code-Review+1

> I'm not sure whether one can still run 1 half rate codec in 1 TCH/F
 > (allocating all of it). Of curse it's not optimal but maybe still
 > possible. If that's the case, we should fix osmo-bsc to allow it
 > (maybe print a warning a t startup).


--
To view, visit https://gerrit.osmocom.org/11502
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
Gerrit-Change-Number: 11502
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 29 Oct 2018 16:54:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: defaults.conf: Set valid default codec_list matching avail TS types

2018-10-29 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11502 )

Change subject: defaults.conf: Set valid default codec_list matching avail TS 
types
..


Patch Set 1:

I'm not sure whether one can still run 1 half rate codec in 1 TCH/F (allocating 
all of it). Of curse it's not optimal but maybe still possible. If that's the 
case, we should fix osmo-bsc to allow it (maybe print a warning a t startup).


--
To view, visit https://gerrit.osmocom.org/11502
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
Gerrit-Change-Number: 11502
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Jenkins Builder (102)
Gerrit-Comment-Date: Mon, 29 Oct 2018 16:52:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: defaults.conf: Set valid default codec_list matching avail TS types

2018-10-29 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11502


Change subject: defaults.conf: Set valid default codec_list matching avail TS 
types
..

defaults.conf: Set valid default codec_list matching avail TS types

By default, all channels are TCH/F, and as a result we cannot run half
rate codecs on it.

Since recent versions of osmo-bsc, it checks this kind of
misconfigurations and answers with an Assignment Failure:

20181029162133430 DMSC <0007> codec_pref.c:445 codec-support/trx config of BTS 
0 does not intersect with codec-list of MSC 0
20181029162133430 DMSC <0007> osmo_bsc_main.c:887 Configuration contains 
mutually exclusive codec settings -- check configuration!

20181029162255253 DMSC <0007> osmo_bsc_bssap.c:859 Rx MSC DT1 BSSMAP ASSIGNMENT 
REQ
20181029162255254 DMSC <0007> osmo_bsc_bssap.c:718 No supported audio type 
found for channel_type = { ch_indctr=0x1, ch_rate_type=0xa, perm_spch=[ 42 21 
11 01 25 05 ]

Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
---
M example/defaults.conf
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/02/11502/1

diff --git a/example/defaults.conf b/example/defaults.conf
index dc38030..1855883 100644
--- a/example/defaults.conf
+++ b/example/defaults.conf
@@ -15,7 +15,7 @@
 long_name: osmo-gsm-tester-msc
 encryption: a5_0
 codec_list:
-- hr3
+- fr1

 msc:
   net:

--
To view, visit https://gerrit.osmocom.org/11502
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6b37839fe363b5d1ba64c267d751221434cdedb
Gerrit-Change-Number: 11502
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol