Change in osmo-gsm-tester[master]: rfemu_srsenb_stdin: use negative dB value to set attenuation

2020-10-13 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641 )

Change subject: rfemu_srsenb_stdin: use negative dB value to set attenuation
..

rfemu_srsenb_stdin: use negative dB value to set attenuation

the logic for the RF emulator on the command line is, like the
Amarisoft equivalent, to set a negative gain value to express
attenuation. Therefore, the sign needs to be inverted.

Change-Id: I7b6ac611a9f711bbdc1570602bfd797a5346ab86
---
M src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved; Verified



diff --git a/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py 
b/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
index ca23020..e4aec19 100644
--- a/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
+++ b/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
@@ -42,7 +42,7 @@
 # PUBLIC (test API included)
 #
 def set_attenuation(self, db):
-msg_str = 'cell_gain %d %f' % (self.cell_id, db)
+msg_str = 'cell_gain %d %f' % (self.cell_id, -db)
 self.dbg('sending stdin msg: "%s"' % msg_str)
 self.enb.process.stdin_write(msg_str + '\n')


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7b6ac611a9f711bbdc1570602bfd797a5346ab86
Gerrit-Change-Number: 20641
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-gsm-tester[master]: rfemu_srsenb_stdin: use negative dB value to set attenuation

2020-10-13 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641 )

Change subject: rfemu_srsenb_stdin: use negative dB value to set attenuation
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7b6ac611a9f711bbdc1570602bfd797a5346ab86
Gerrit-Change-Number: 20641
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 13 Oct 2020 18:54:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-gsm-tester[master]: rfemu_srsenb_stdin: use negative dB value to set attenuation

2020-10-13 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641 )

Change subject: rfemu_srsenb_stdin: use negative dB value to set attenuation
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7b6ac611a9f711bbdc1570602bfd797a5346ab86
Gerrit-Change-Number: 20641
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 13 Oct 2020 18:54:59 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-gsm-tester[master]: rfemu_srsenb_stdin: use negative dB value to set attenuation

2020-10-13 Thread srs_andre 
srs_andre has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641 )


Change subject: rfemu_srsenb_stdin: use negative dB value to set attenuation
..

rfemu_srsenb_stdin: use negative dB value to set attenuation

the logic for the RF emulator on the command line is, like the
Amarisoft equivalent, to set a negative gain value to express
attenuation. Therefore, the sign needs to be inverted.

Change-Id: I7b6ac611a9f711bbdc1570602bfd797a5346ab86
---
M src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/41/20641/1

diff --git a/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py 
b/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
index ca23020..e4aec19 100644
--- a/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
+++ b/src/osmo_gsm_tester/obj/rfemu_srsenb_stdin.py
@@ -42,7 +42,7 @@
 # PUBLIC (test API included)
 #
 def set_attenuation(self, db):
-msg_str = 'cell_gain %d %f' % (self.cell_id, db)
+msg_str = 'cell_gain %d %f' % (self.cell_id, -db)
 self.dbg('sending stdin msg: "%s"' % msg_str)
 self.enb.process.stdin_write(msg_str + '\n')


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I7b6ac611a9f711bbdc1570602bfd797a5346ab86
Gerrit-Change-Number: 20641
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-MessageType: newchange