Change in osmo-gsm-tester[master]: srsue.conf.tmpl: Adjust ue.config template for new pcap path

2021-03-16 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339 )

Change subject: srsue.conf.tmpl: Adjust ue.config template for new pcap path
..

srsue.conf.tmpl: Adjust ue.config template for new pcap path

Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  pespin: Looks good to me, approved; Verified



diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index 272ae48..a922dc8 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -78,10 +78,10 @@
 # nas_filename: File path to use for NAS packet captures
 #
 [pcap]
-enable = ${'true' if ue.enable_pcap else 'false'}
-filename = ${ue.pcap_filename}
-nas_enable = false
-nas_filename = /tmp/nas.pcap
+enable = ${'mac' if ue.enable_pcap else 'none'}
+mac_filename = ${ue.pcap_filename}
+mac_nr_filename = /tmp/ue_mac_nr.pcap
+nas_filename = /tmp/ue_nas.pcap

 #
 # Log configuration

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
Gerrit-Change-Number: 23339
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: Adjust ue.config template for new pcap path

2021-03-16 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339 )

Change subject: srsue.conf.tmpl: Adjust ue.config template for new pcap path
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
Gerrit-Change-Number: 23339
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 16 Mar 2021 17:05:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: Adjust ue.config template for new pcap path

2021-03-12 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339 )

Change subject: srsue.conf.tmpl: Adjust ue.config template for new pcap path
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339/1/src/osmo_gsm_tester/templates/srsue.conf.tmpl
File src/osmo_gsm_tester/templates/srsue.conf.tmpl:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339/1/src/osmo_gsm_tester/templates/srsue.conf.tmpl@84
PS1, Line 84: nas_filename = /tmp/ue_nas.pcap
These paths should probably be go to the rundir prefix of the object? otherwise 
parallel srsue processes are writing to same path.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
Gerrit-Change-Number: 23339
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:34:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: Adjust ue.config template for new pcap path

2021-03-12 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339 )

Change subject: srsue.conf.tmpl: Adjust ue.config template for new pcap path
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
Gerrit-Change-Number: 23339
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:33:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: Adjust ue.config template for new pcap path

2021-03-12 Thread srs_andre
srs_andre has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339 )


Change subject: srsue.conf.tmpl: Adjust ue.config template for new pcap path
..

srsue.conf.tmpl: Adjust ue.config template for new pcap path

Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/39/23339/1

diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index 272ae48..a922dc8 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -78,10 +78,10 @@
 # nas_filename: File path to use for NAS packet captures
 #
 [pcap]
-enable = ${'true' if ue.enable_pcap else 'false'}
-filename = ${ue.pcap_filename}
-nas_enable = false
-nas_filename = /tmp/nas.pcap
+enable = ${'mac' if ue.enable_pcap else 'none'}
+mac_filename = ${ue.pcap_filename}
+mac_nr_filename = /tmp/ue_mac_nr.pcap
+nas_filename = /tmp/ue_nas.pcap

 #
 # Log configuration

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/23339
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I4af6abaa3973652a12f571d88bca59cd443704f3
Gerrit-Change-Number: 23339
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-MessageType: newchange