Change in osmo-gsm-tester[master]: virtual: The completion ratio is success / success+failure

2019-04-29 Thread Holger Freyther 
Holger Freyther has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13803 )

Change subject: virtual: The completion ratio is success / success+failure
..

virtual: The completion ratio is success / success+failure

Fix the stats code to calculate the real completion ratio.

Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
---
M suites/nitb_netreg_mass/register_default_mass.py
M suites/nitb_netreg_mass/suite.conf
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/suites/nitb_netreg_mass/register_default_mass.py 
b/suites/nitb_netreg_mass/register_default_mass.py
index 76c53f1..306eb81 100644
--- a/suites/nitb_netreg_mass/register_default_mass.py
+++ b/suites/nitb_netreg_mass/register_default_mass.py
@@ -38,7 +38,7 @@
 stats = ms_driver.get_stats()
 if len(modems) > 0 and stats.num_completed < 1:
 raise Exception("No run completed.")
-completion_ratio = stats.num_attempted / stats.num_completed
+completion_ratio = stats.num_completed / stats.num_attempted

 # Verify that 99% of LUs completed.
 if completion_ratio < 0.99:
diff --git a/suites/nitb_netreg_mass/suite.conf 
b/suites/nitb_netreg_mass/suite.conf
index 44de0b6..bb1585b 100644
--- a/suites/nitb_netreg_mass/suite.conf
+++ b/suites/nitb_netreg_mass/suite.conf
@@ -8,4 +8,4 @@
 type: osmo-mobile

 defaults:
-  timeout: 40s
+  timeout: 50s

--
To view, visit https://gerrit.osmocom.org/13803
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: virtual: The completion ratio is success / success+failure

2019-04-28 Thread Holger Freyther 
Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/13803 )

Change subject: virtual: The completion ratio is success / success+failure
..


Patch Set 2:

(1 comment)

> Patch Set 2: Code-Review+2
>
> (1 comment)

https://gerrit.osmocom.org/#/c/13803/2/suites/nitb_netreg_mass/suite.conf
File suites/nitb_netreg_mass/suite.conf:

https://gerrit.osmocom.org/#/c/13803/2/suites/nitb_netreg_mass/suite.conf@11
PS2, Line 11:   timeout: 50s
> This change is actually unrelated but fine.
Now that the ratio can be < 1.0 we need some more time to make the test pass. ;)



--
To view, visit https://gerrit.osmocom.org/13803
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 28 Apr 2019 14:50:48 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: virtual: The completion ratio is success / success+failure

2019-04-28 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/13803 )

Change subject: virtual: The completion ratio is success / success+failure
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13803/2/suites/nitb_netreg_mass/suite.conf
File suites/nitb_netreg_mass/suite.conf:

https://gerrit.osmocom.org/#/c/13803/2/suites/nitb_netreg_mass/suite.conf@11
PS2, Line 11:   timeout: 50s
This change is actually unrelated but fine.



--
To view, visit https://gerrit.osmocom.org/13803
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 28 Apr 2019 14:27:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: virtual: The completion ratio is success / success+failure

2019-04-28 Thread Holger Freyther 
Holger Freyther has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/13803 )

Change subject: virtual: The completion ratio is success / success+failure
..

virtual: The completion ratio is success / success+failure

Fix the stats code to calculate the real completion ratio.

Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
---
M suites/nitb_netreg_mass/register_default_mass.py
M suites/nitb_netreg_mass/suite.conf
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/03/13803/2
--
To view, visit https://gerrit.osmocom.org/13803
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther

Change in osmo-gsm-tester[master]: virtual: The completion ratio is success / success+failure

2019-04-28 Thread Holger Freyther 
Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/13803


Change subject: virtual: The completion ratio is success / success+failure
..

virtual: The completion ratio is success / success+failure

Fix the stats code to calculate the real completion ratio.

Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
---
M suites/nitb_netreg_mass/register_default_mass.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/03/13803/1

diff --git a/suites/nitb_netreg_mass/register_default_mass.py 
b/suites/nitb_netreg_mass/register_default_mass.py
index 76c53f1..306eb81 100644
--- a/suites/nitb_netreg_mass/register_default_mass.py
+++ b/suites/nitb_netreg_mass/register_default_mass.py
@@ -38,7 +38,7 @@
 stats = ms_driver.get_stats()
 if len(modems) > 0 and stats.num_completed < 1:
 raise Exception("No run completed.")
-completion_ratio = stats.num_attempted / stats.num_completed
+completion_ratio = stats.num_completed / stats.num_attempted

 # Verify that 99% of LUs completed.
 if completion_ratio < 0.99:

--
To view, visit https://gerrit.osmocom.org/13803
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther