Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

2019-02-28 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 28 Feb 2019 13:27:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

2019-02-26 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..

hlr.c: move hlr_ctx to the top

Allow all functions to use hlr_ctx, so it can be used by the upcoming
read_cb_forward() function in [1]. That new function is placed next to
the existing read_cb() function, which is above the current hlr_ctx
declaration.

[1]: Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5

Related: OS#3793
Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
---
M src/hlr.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/hlr.c b/src/hlr.c
index c544310..f374ccc 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -47,6 +47,7 @@
 #include "hlr_ussd.h"

 struct hlr *g_hlr;
+static void *hlr_ctx = NULL;
 static int quit = 0;

 /* Trigger 'Insert Subscriber Data' messages to all connected GSUP clients.
@@ -608,8 +609,6 @@
}
 }

-static void *hlr_ctx = NULL;
-
 static void signal_hdlr(int signal)
 {
switch (signal) {

--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

2019-02-26 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:10:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

2019-02-26 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/13050 )

Change subject: hlr.c: move hlr_ctx to the top
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Daniel Willmann 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 26 Feb 2019 16:49:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: hlr.c: move hlr_ctx to the top

2019-02-26 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13050


Change subject: hlr.c: move hlr_ctx to the top
..

hlr.c: move hlr_ctx to the top

Allow all functions to use hlr_ctx, so it can be used by the upcoming
read_cb_forward() function in [1]. That new function is placed next to
the existing read_cb() function, which is above the current hlr_ctx
declaration.

[1]: Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5

Related: OS#3793
Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
---
M src/hlr.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/50/13050/1

diff --git a/src/hlr.c b/src/hlr.c
index c544310..f374ccc 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -47,6 +47,7 @@
 #include "hlr_ussd.h"

 struct hlr *g_hlr;
+static void *hlr_ctx = NULL;
 static int quit = 0;

 /* Trigger 'Insert Subscriber Data' messages to all connected GSUP clients.
@@ -608,8 +609,6 @@
}
 }

-static void *hlr_ctx = NULL;
-
 static void signal_hdlr(int signal)
 {
switch (signal) {

--
To view, visit https://gerrit.osmocom.org/13050
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5edf0a233ff323a63e321a1ca47736b5b212d1bb
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 1
Gerrit-Owner: osmith