Change in osmo-iuh[master]: hnbgw_tx_hnb_register_rej(): Missing return statement

2018-10-21 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11400 )

Change subject: hnbgw_tx_hnb_register_rej(): Missing return statement
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 21 Oct 2018 11:41:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-iuh[master]: hnbgw_tx_hnb_register_rej(): Missing return statement

2018-10-21 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11400 )

Change subject: hnbgw_tx_hnb_register_rej(): Missing return statement
..

hnbgw_tx_hnb_register_rej(): Missing return statement

Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Fixes: Coverity CID#188869
---
M src/hnbgw_hnbap.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 2a19dda..1d50d4d 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -85,7 +85,10 @@
} else {
/* The message was not queued. Destroy the connection right 
away. */
hnb_context_release(ctx);
+   return rc;
}
+
+   return 0;
 }

 static int hnbgw_tx_hnb_register_acc(struct hnb_context *ctx)

--
To view, visit https://gerrit.osmocom.org/11400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-iuh[master]: hnbgw_tx_hnb_register_rej(): Missing return statement

2018-10-21 Thread Harald Welte 
Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/11400


Change subject: hnbgw_tx_hnb_register_rej(): Missing return statement
..

hnbgw_tx_hnb_register_rej(): Missing return statement

Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Fixes: Coverity CID#188869
---
M src/hnbgw_hnbap.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/00/11400/1

diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 2a19dda..1d50d4d 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -85,7 +85,10 @@
} else {
/* The message was not queued. Destroy the connection right 
away. */
hnb_context_release(ctx);
+   return rc;
}
+
+   return 0;
 }

 static int hnbgw_tx_hnb_register_acc(struct hnb_context *ctx)

--
To view, visit https://gerrit.osmocom.org/11400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bdee8ede9ffdc16c16a4f5723acb7b4bceb2158
Gerrit-Change-Number: 11400
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte