Change in osmo-msc[master]: Allow MME name preformatted as FQDN in SGsAP
Omar Ramadan has submitted this change and it was merged. (
https://gerrit.osmocom.org/13627 )
Change subject: Allow MME name preformatted as FQDN in SGsAP
..
Allow MME name preformatted as FQDN in SGsAP
Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
---
M src/libmsc/sgs_iface.c
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index eed107a..8b4b61d 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -168,6 +168,12 @@
if (!mme_name_enc)
return -EINVAL;
+ /* some implementations use FDQN format violating TS 29.118 9.3.14 */
+ if (!osmo_parse_mme_domain(&gummei, (const char *) mme_name_enc)) {
+ memcpy(mme_name, mme_name_enc, TLVP_LEN(tp, SGSAP_IE_MME_NAME));
+ return 0;
+ }
+
/* decode the MME name from DNS labels to string */
osmo_apn_to_str(mme_name, TLVP_VAL(tp, SGSAP_IE_MME_NAME), TLVP_LEN(tp,
SGSAP_IE_MME_NAME));
--
To view, visit https://gerrit.osmocom.org/13627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
Gerrit-Change-Number: 13627
Gerrit-PatchSet: 2
Gerrit-Owner: Omar Ramadan
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Omar Ramadan
Change in osmo-msc[master]: Allow MME name preformatted as FQDN in SGsAP
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13627 ) Change subject: Allow MME name preformatted as FQDN in SGsAP .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9 Gerrit-Change-Number: 13627 Gerrit-PatchSet: 1 Gerrit-Owner: Omar Ramadan Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Sat, 13 Apr 2019 21:37:09 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: Allow MME name preformatted as FQDN in SGsAP
Omar Ramadan has uploaded this change for review. (
https://gerrit.osmocom.org/13627
Change subject: Allow MME name preformatted as FQDN in SGsAP
..
Allow MME name preformatted as FQDN in SGsAP
Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
---
M src/libmsc/sgs_iface.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/13627/1
diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index f64b191..9ad8021 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -167,6 +167,12 @@
if (!mme_name_enc)
return -EINVAL;
+ /* some implementations use FDQN format violating TS 29.118 9.3.14 */
+ if (!osmo_parse_mme_domain(&gummei, (const char *) mme_name_enc)) {
+ memcpy(mme_name, mme_name_enc, TLVP_LEN(tp, SGSAP_IE_MME_NAME));
+ return 0;
+ }
+
/* decode the MME name from DNS labels to string */
osmo_apn_to_str(mme_name, TLVP_VAL(tp, SGSAP_IE_MME_NAME), TLVP_LEN(tp,
SGSAP_IE_MME_NAME));
--
To view, visit https://gerrit.osmocom.org/13627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
Gerrit-Change-Number: 13627
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Ramadan
