Change in osmo-msc[master]: Fix build with latest libosmocore

2019-01-21 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11821 )

Change subject: Fix build with latest libosmocore
..


Patch Set 2:

This is the wrong solution.  Old programs *must* always build against new 
libosmocore.  This "fix" has just postponed the problem: Now that we have a new 
libosmocore (1.0.0) tagged, but not yet osmo-msc, the "latest" feeds fail to 
build: 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/x86_64


--
To view, visit https://gerrit.osmocom.org/11821
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I464c16034b76e4599ac42857f60442c3fd000c75
Gerrit-Change-Number: 11821
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 21 Jan 2019 13:18:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: Fix build with latest libosmocore

2018-11-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11821 )

Change subject: Fix build with latest libosmocore
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11821
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I464c16034b76e4599ac42857f60442c3fd000c75
Gerrit-Change-Number: 11821
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 19 Nov 2018 09:48:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Fix build with latest libosmocore

2018-11-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11821 )

Change subject: Fix build with latest libosmocore
..

Fix build with latest libosmocore

Remove locally defined function which conflicts with the one in
libosmocore.

Change-Id: I464c16034b76e4599ac42857f60442c3fd000c75
---
M src/libmsc/gsm_04_80.c
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_80.c b/src/libmsc/gsm_04_80.c
index 0adf059..81f2001 100644
--- a/src/libmsc/gsm_04_80.c
+++ b/src/libmsc/gsm_04_80.c
@@ -33,15 +33,6 @@
 #include 
 #include 

-static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, uint8_t tag)
-{
-   uint8_t *data = msgb_push(msgb, 2);
-
-   data[0] = tag;
-   data[1] = msgb->len - 2;
-   return data;
-}
-
 /*! Send a MT RELEASE COMPLETE message with Reject component
  *  (see section 3.6.1) and given error code (see section 3.6.7).
  *

--
To view, visit https://gerrit.osmocom.org/11821
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I464c16034b76e4599ac42857f60442c3fd000c75
Gerrit-Change-Number: 11821
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-msc[master]: Fix build with latest libosmocore

2018-11-19 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11821


Change subject: Fix build with latest libosmocore
..

Fix build with latest libosmocore

Remove locally defined function which conflicts with the one in
libosmocore.

Change-Id: I464c16034b76e4599ac42857f60442c3fd000c75
---
M src/libmsc/gsm_04_80.c
1 file changed, 0 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/21/11821/1

diff --git a/src/libmsc/gsm_04_80.c b/src/libmsc/gsm_04_80.c
index 0adf059..81f2001 100644
--- a/src/libmsc/gsm_04_80.c
+++ b/src/libmsc/gsm_04_80.c
@@ -33,15 +33,6 @@
 #include 
 #include 

-static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, uint8_t tag)
-{
-   uint8_t *data = msgb_push(msgb, 2);
-
-   data[0] = tag;
-   data[1] = msgb->len - 2;
-   return data;
-}
-
 /*! Send a MT RELEASE COMPLETE message with Reject component
  *  (see section 3.6.1) and given error code (see section 3.6.7).
  *

--
To view, visit https://gerrit.osmocom.org/11821
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I464c16034b76e4599ac42857f60442c3fd000c75
Gerrit-Change-Number: 11821
Gerrit-PatchSet: 1
Gerrit-Owner: Max