Change in osmo-msc[master]: Log: don't print CallRef prefix

2019-05-10 Thread Harald Welte 
Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/12570 )

Change subject: Log: don't print CallRef prefix
..


Abandoned

osmo-msc has changed too much
--
To view, visit https://gerrit.osmocom.org/12570
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Gerrit-Change-Number: 12570
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-msc[master]: Log: don't print CallRef prefix

2019-01-15 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12570 )

Change subject: Log: don't print CallRef prefix
..


Patch Set 2: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/#/c/12570/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12570/2//COMMIT_MSG@9
PS2, Line 9: let's update test output by
   : ignoring first byte of callref
In case of transaction ID, I wasn't sure if we should remove TI flag,
but here I am definitely against. I don't see any advantages of removing
the first byte of callref, vice versa, I see a few potential problems:

  - Let's say we have a few transactions (SMS + USSD during a call):
CC=0x8001, SMS=0x4001, NCSS=0x2001. Without the
prefix, they would all look like a single transaction in logging.

  - We have no any protection against possible overlaps between the
callref ranges (0x20..., 0x40..., 0x80...). This patch makes
impossible to detect such situations in logging.

Instead, I would drop this range (or per-protocol namespace) separation
itself, because I don't see any benefits of this concept.



--
To view, visit https://gerrit.osmocom.org/12570
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Gerrit-Change-Number: 12570
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 15 Jan 2019 18:01:57 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Log: don't print CallRef prefix

2019-01-15 Thread Max 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12570

to look at the new patch set (#2).

Change subject: Log: don't print CallRef prefix
..

Log: don't print CallRef prefix

In a preparation for upcoming CallRef fixes, let's update test output by
ignoring first byte of callref (which acts as per-protocol namespace
indicator anyway) and print protocol name instead.

Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Related: OS#3294
---
M include/osmocom/msc/debug.h
M src/libmsc/transaction.c
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_test_gsm_authen.err
M tests/msc_vlr/msc_vlr_test_gsm_ciph.err
M tests/msc_vlr/msc_vlr_test_ms_timeout.err
M tests/msc_vlr/msc_vlr_test_no_authen.err
M tests/msc_vlr/msc_vlr_test_reject_concurrency.err
M tests/msc_vlr/msc_vlr_test_ss.err
M tests/msc_vlr/msc_vlr_test_umts_authen.err
M tests/msc_vlr/msc_vlr_tests.c
11 files changed, 52 insertions(+), 50 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/70/12570/2
--
To view, visit https://gerrit.osmocom.org/12570
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Gerrit-Change-Number: 12570
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-msc[master]: Log: don't print CallRef prefix

2019-01-15 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12570


Change subject: Log: don't print CallRef prefix
..

Log: don't print CallRef prefix

In a preparation for upcoming CallRef fixes, let's update test output by
ignoring first byte of callref (which acts as per-protocol namespace
indicator anyway) and print protocol name instead.

Change-Id: Icae21a44c7d4010145bcb570187ce9b58092e5a9
Related: OS#3294
---
M src/libmsc/transaction.c
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_test_gsm_authen.err
M tests/msc_vlr/msc_vlr_test_gsm_ciph.err
M tests/msc_vlr/msc_vlr_test_ms_timeout.err
M tests/msc_vlr/msc_vlr_test_no_authen.err
M tests/msc_vlr/msc_vlr_test_reject_concurrency.err
M tests/msc_vlr/msc_vlr_test_ss.err
M tests/msc_vlr/msc_vlr_test_umts_authen.err
9 files changed, 27 insertions(+), 27 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/70/12570/1

diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c
index df770ed..01cb2ba 100644
--- a/src/libmsc/transaction.c
+++ b/src/libmsc/transaction.c
@@ -114,8 +114,8 @@
return NULL;
}

-   DEBUGP(DCC, "(ti %02x sub %s callref %x) New transaction\n",
-  trans_id, vlr_subscr_name(vsub), callref);
+   DEBUGP(DCC, "(ti %02x sub %s callref %x) New transaction for %s\n",
+  trans_id, vlr_subscr_name(vsub), (callref << 8) >> 8, 
gsm48_pdisc_name(protocol));

trans = talloc_zero(tall_trans_ctx, struct gsm_trans);
if (!trans)
diff --git a/tests/msc_vlr/msc_vlr_test_call.err 
b/tests/msc_vlr/msc_vlr_test_call.err
index f190c31..b6cd460 100644
--- a/tests/msc_vlr/msc_vlr_test_call.err
+++ b/tests/msc_vlr/msc_vlr_test_call.err
@@ -271,7 +271,7 @@
 DREF IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: MSC conn use + dtap == 
2 (0xa: dtap,cm_service)
 DRLL Dispatching 04.08 message GSM48_MT_CC_SETUP (0x3:0x5)
 DCC Unknown transaction ID 8, creating new trans.
-DCC (ti 08 sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 
8001) New transaction
+DCC (ti 08 sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 1) 
New transaction for CC
 DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 usage 
increases to: 3
 DREF IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: MSC conn use + 
trans_cc == 3 (0x1a: dtap,cm_service,trans_cc)
 DMM IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: rx msg 
GSM48_MT_CC_SETUP: received_cm_service_request changes to false
@@ -574,7 +574,7 @@
 - after a while, MNCC asks us to setup a call, causing Paging
 DMNCC receive message MNCC_SETUP_REQ
 DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 usage 
increases to: 2
-DCC (ti ff sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 423) 
New transaction
+DCC (ti ff sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 423) 
New transaction for CC
 DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 usage 
increases to: 3
 DMM Subscriber IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 not paged 
yet, start paging.
   UTRAN-Iu sends out paging request to IMSI 90170010650, TMSI 0x03020100, 
LAC 23
@@ -960,7 +960,7 @@
 - after a while, MNCC asks us to setup a call, causing Paging
 DMNCC receive message MNCC_SETUP_REQ
 DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 usage 
increases to: 2
-DCC (ti ff sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 423) 
New transaction
+DCC (ti ff sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 423) 
New transaction for CC
 DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 usage 
increases to: 3
 DMM Subscriber IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 not paged 
yet, start paging.
   UTRAN-Iu sends out paging request to IMSI 90170010650, TMSI 0x03020100, 
LAC 23
@@ -1396,7 +1396,7 @@
 DREF IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: MSC conn use + dtap == 
2 (0xa: dtap,cm_service)
 DRLL Dispatching 04.08 message GSM48_MT_CC_SETUP (0x3:0x5)
 DCC Unknown transaction ID 8, creating new trans.
-DCC (ti 08 sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 
8002) New transaction
+DCC (ti 08 sub IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 callref 2) 
New transaction for CC
 DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 usage 
increases to: 3
 DREF IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: MSC conn use + 
trans_cc == 3 (0x1a: dtap,cm_service,trans_cc)
 DMM IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: rx msg 
GSM48_MT_CC_SETUP: received_cm_service_request changes to false
@@ -1745,7 +1745,7 @@
 DREF IMSI-90170010650:MSISDN-42342:TMSI-0x03020100: MSC conn use + dtap == 
2 (0xa: dtap,cm_service)
 DRLL Dispatching 04.08 message GSM48_MT_CC_SETUP (0x3:0x5)
 DCC Unknown transaction ID 8, creating new trans.
-DCC (ti 08 sub IMSI-90170010