Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12337 )
Change subject: VLR tests: avoid leaking LAC access details
..
VLR tests: avoid leaking LAC access details
Avoid leaking details on accessing data structure for LAC value into
test output: that's irrelevant clutter which forces unnecessary test
output modifications.
Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e
---
M tests/msc_vlr/msc_vlr_test_call.c
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_test_ss.c
M tests/msc_vlr/msc_vlr_test_ss.err
4 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Jenkins Builder: Verified
Max: Looks good to me, approved
diff --git a/tests/msc_vlr/msc_vlr_test_call.c
b/tests/msc_vlr/msc_vlr_test_call.c
index ef88c5a..4a4f243 100644
--- a/tests/msc_vlr/msc_vlr_test_call.c
+++ b/tests/msc_vlr/msc_vlr_test_call.c
@@ -154,7 +154,7 @@
vsub = vlr_subscr_find_by_imsi(net->vlr, IMSI);
VERBOSE_ASSERT(vsub != NULL, == true, "%d");
VERBOSE_ASSERT(strcmp(vsub->imsi, IMSI), == 0, "%d");
- VERBOSE_ASSERT(vsub->lac, == 23, "%u");
+ VAL_ASSERT("LAC", vsub->lac, == 23, "%u");
vlr_subscr_put(vsub);
}
diff --git a/tests/msc_vlr/msc_vlr_test_call.err
b/tests/msc_vlr/msc_vlr_test_call.err
index 481a2db..db0d58c 100644
--- a/tests/msc_vlr/msc_vlr_test_call.err
+++ b/tests/msc_vlr/msc_vlr_test_call.err
@@ -175,7 +175,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, a new conn sends a CM Service Request. VLR responds with Auth
Req, 2nd auth vector
@@ -555,7 +555,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, MNCC asks us to setup a call, causing Paging
@@ -934,7 +934,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, MNCC asks us to setup a call, causing Paging
@@ -1279,7 +1279,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, a new conn sends a CM Service Request. VLR responds with Auth
Req, 2nd auth vector
@@ -1621,7 +1621,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, a new conn sends a CM Service Request. VLR responds with Auth
Req, 2nd auth vector
diff --git a/tests/msc_vlr/msc_vlr_test_ss.c b/tests/msc_vlr/msc_vlr_test_ss.c
index 34aa634..4e8077e 100644
--- a/tests/msc_vlr/msc_vlr_test_ss.c
+++ b/tests/msc_vlr/msc_vlr_test_ss.c
@@ -68,7 +68,7 @@
vsub = vlr_subscr_find_by_imsi(net->vlr, IMSI);
VERBOSE_ASSERT(vsub != NULL, == true, "%d");
VERBOSE_ASSERT(strcmp(vsub->imsi, IMSI), == 0, "%d");
- VERBOSE_ASSERT(vsub->lac, == 23, "%u");
+ VAL_ASSERT("LAC", vsub->lac, == 23, "%u");
vlr_subscr_put(vsub);
bss_sends_clear_complete();
diff --git a/tests/msc_vlr/msc_vlr_test_ss.err
b/tests/msc_vlr/msc_vlr_test_ss.err
index fe869ad..1d4a0c6 100644
--- a/tests/msc_vlr/msc_vlr_test_ss.err
+++ b/tests/msc_vlr/msc_vlr_test_ss.err
@@ -91,7 +91,7 @@
DREF VLR subscr MSISDN:46071 usage increases to: 3
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:46071 usage decreases to: 2
- BSS sends BSSMAP Clear Complete
DREF MSISDN:46071: MSC conn use - release == 0 (0x0: )
@@ -287,7 +287,7 @@
DREF VLR subscr MSISDN:46071 usage increases to: 3
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:46071 usage decreases to: 2
- BSS sends BSSMAP Clear Complete
DREF MSISDN:46071: MSC conn use - release == 0 (0x0: )
--
To view, visit https://gerrit.osmocom.org/12337
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e
Gerrit-Change-Number: 12337
Gerrit-PatchSet: 3
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: Stefan Sperling
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Max has posted comments on this change. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 14:47:53 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Hello Stefan Sperling, Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12337 to look at the new patch set (#3). Change subject: VLR tests: avoid leaking LAC access details .. VLR tests: avoid leaking LAC access details Avoid leaking details on accessing data structure for LAC value into test output: that's irrelevant clutter which forces unnecessary test output modifications. Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_ss.c M tests/msc_vlr/msc_vlr_test_ss.err 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/12337/3 -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Max has posted comments on this change. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. Patch Set 2: Code-Review+2 Trivial macro rename from earlier revision which got +2 already. -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 14:33:22 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 14:31:36 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Hello Stefan Sperling, Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12337 to look at the new patch set (#2). Change subject: VLR tests: avoid leaking LAC access details .. VLR tests: avoid leaking LAC access details Avoid leaking details on accessing data structure for LAC value into test output: that's irrelevant clutter which forces unnucessary test output modifications. Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_ss.c M tests/msc_vlr/msc_vlr_test_ss.err 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/12337/2 -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. Patch Set 1: Code-Review+1 (1 comment) Yes I agree this is better. https://gerrit.osmocom.org/#/c/12337/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12337/1//COMMIT_MSG@10 PS1, Line 10: test output: that's irrelevant clutter which forces unnucessary test typo: "unnecessary" -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Tue, 18 Dec 2018 11:09:30 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12337 ) Change subject: VLR tests: avoid leaking LAC access details .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e Gerrit-Change-Number: 12337 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Stefan Sperling Gerrit-Comment-Date: Mon, 17 Dec 2018 17:44:22 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-msc[master]: VLR tests: avoid leaking LAC access details
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12337
Change subject: VLR tests: avoid leaking LAC access details
..
VLR tests: avoid leaking LAC access details
Avoid leaking details on accessing data structure for LAC value into
test output: that's irrelevant clutter which forces unnucessary test
output modifications.
Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e
---
M tests/msc_vlr/msc_vlr_test_call.c
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_test_ss.c
M tests/msc_vlr/msc_vlr_test_ss.err
4 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/12337/1
diff --git a/tests/msc_vlr/msc_vlr_test_call.c
b/tests/msc_vlr/msc_vlr_test_call.c
index ef88c5a..83bc84b 100644
--- a/tests/msc_vlr/msc_vlr_test_call.c
+++ b/tests/msc_vlr/msc_vlr_test_call.c
@@ -154,7 +154,7 @@
vsub = vlr_subscr_find_by_imsi(net->vlr, IMSI);
VERBOSE_ASSERT(vsub != NULL, == true, "%d");
VERBOSE_ASSERT(strcmp(vsub->imsi, IMSI), == 0, "%d");
- VERBOSE_ASSERT(vsub->lac, == 23, "%u");
+ V_ASSERT("LAC", vsub->lac, == 23, "%u");
vlr_subscr_put(vsub);
}
diff --git a/tests/msc_vlr/msc_vlr_test_call.err
b/tests/msc_vlr/msc_vlr_test_call.err
index 481a2db..db0d58c 100644
--- a/tests/msc_vlr/msc_vlr_test_call.err
+++ b/tests/msc_vlr/msc_vlr_test_call.err
@@ -175,7 +175,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, a new conn sends a CM Service Request. VLR responds with Auth
Req, 2nd auth vector
@@ -555,7 +555,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, MNCC asks us to setup a call, causing Paging
@@ -934,7 +934,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, MNCC asks us to setup a call, causing Paging
@@ -1279,7 +1279,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, a new conn sends a CM Service Request. VLR responds with Auth
Req, 2nd auth vector
@@ -1621,7 +1621,7 @@
DREF VLR subscr MSISDN:42342 usage increases to: 2
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:42342 usage decreases to: 1
---
- after a while, a new conn sends a CM Service Request. VLR responds with Auth
Req, 2nd auth vector
diff --git a/tests/msc_vlr/msc_vlr_test_ss.c b/tests/msc_vlr/msc_vlr_test_ss.c
index 34aa634..d8167bd 100644
--- a/tests/msc_vlr/msc_vlr_test_ss.c
+++ b/tests/msc_vlr/msc_vlr_test_ss.c
@@ -68,7 +68,7 @@
vsub = vlr_subscr_find_by_imsi(net->vlr, IMSI);
VERBOSE_ASSERT(vsub != NULL, == true, "%d");
VERBOSE_ASSERT(strcmp(vsub->imsi, IMSI), == 0, "%d");
- VERBOSE_ASSERT(vsub->lac, == 23, "%u");
+ V_ASSERT("LAC", vsub->lac, == 23, "%u");
vlr_subscr_put(vsub);
bss_sends_clear_complete();
diff --git a/tests/msc_vlr/msc_vlr_test_ss.err
b/tests/msc_vlr/msc_vlr_test_ss.err
index fe869ad..1d4a0c6 100644
--- a/tests/msc_vlr/msc_vlr_test_ss.err
+++ b/tests/msc_vlr/msc_vlr_test_ss.err
@@ -91,7 +91,7 @@
DREF VLR subscr MSISDN:46071 usage increases to: 3
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:46071 usage decreases to: 2
- BSS sends BSSMAP Clear Complete
DREF MSISDN:46071: MSC conn use - release == 0 (0x0: )
@@ -287,7 +287,7 @@
DREF VLR subscr MSISDN:46071 usage increases to: 3
vsub != NULL == 1
strcmp(vsub->imsi, IMSI) == 0
- vsub->lac == 23
+ LAC == 23
DREF VLR subscr MSISDN:46071 usage decreases to: 2
- BSS sends BSSMAP Clear Complete
DREF MSISDN:46071: MSC conn use - release == 0 (0x0: )
--
To view, visit https://gerrit.osmocom.org/12337
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a1d7884cf47ad513d7d6fb27c5c6f1b829dff2e
Gerrit-Change-Number: 12337
Gerrit-PatchSet: 1
Gerrit-Owner: Max
