Change in osmo-msc[master]: comment: vlr: put the 'balancing' comment closer to the put()

2018-12-17 Thread Neels Hofmeyr 
Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12240 )

Change subject: comment: vlr: put the 'balancing' comment closer to the put()
..

comment: vlr: put the 'balancing' comment closer to the put()

Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
---
M src/libvlr/vlr.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 975b240..7de78bf 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1142,6 +1142,7 @@
 bool vlr_subscr_expire(struct vlr_subscr *vsub)
 {
if (vsub->lu_complete) {
+   /* balancing the get from vlr_lu_compl_fsm_success() */
vsub->lu_complete = false;
vlr_subscr_put(vsub);

@@ -1160,7 +1161,6 @@
vsub->imsi_detached_flag = true;
vsub->expire_lu = VLR_SUBSCRIBER_NO_EXPIRATION;

-   /* balancing the get from vlr_lu_compl_fsm_success() */
vlr_subscr_expire(vsub);

return 0;

--
To view, visit https://gerrit.osmocom.org/12240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
Gerrit-Change-Number: 12240
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-msc[master]: comment: vlr: put the 'balancing' comment closer to the put()

2018-12-12 Thread Max 
Max has posted comments on this change. ( https://gerrit.osmocom.org/12240 )

Change subject: comment: vlr: put the 'balancing' comment closer to the put()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
Gerrit-Change-Number: 12240
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 12 Dec 2018 14:47:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: comment: vlr: put the 'balancing' comment closer to the put()

2018-12-11 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12240 )

Change subject: comment: vlr: put the 'balancing' comment closer to the put()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
Gerrit-Change-Number: 12240
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:55:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: comment: vlr: put the 'balancing' comment closer to the put()

2018-12-11 Thread Neels Hofmeyr 
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12240


Change subject: comment: vlr: put the 'balancing' comment closer to the put()
..

comment: vlr: put the 'balancing' comment closer to the put()

Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
---
M src/libvlr/vlr.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/12240/1

diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 3369914..db9125f 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1141,6 +1141,7 @@
 bool vlr_subscr_expire(struct vlr_subscr *vsub)
 {
if (vsub->lu_complete) {
+   /* balancing the get from vlr_lu_compl_fsm_success() */
vsub->lu_complete = false;
vlr_subscr_put(vsub);

@@ -1159,7 +1160,6 @@
vsub->imsi_detached_flag = true;
vsub->expire_lu = VLR_SUBSCRIBER_NO_EXPIRATION;
 
-   /* balancing the get from vlr_lu_compl_fsm_success() */
vlr_subscr_expire(vsub);

return 0;

--
To view, visit https://gerrit.osmocom.org/12240
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
Gerrit-Change-Number: 12240
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr