Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

2018-10-21 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11414 )

Change subject: gsm0407_is_duplicate(): Handle error ret of 
gsm0407_pdisc_ctr_bin()
..

gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Fixes: Coverity CID#182702
---
M src/libmsc/gsm_04_08.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 0f52d09..d5cc212 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1397,7 +1397,8 @@
 {
struct gsm48_hdr *gh;
uint8_t pdisc;
-   uint8_t n_sd, modulo, bin;
+   uint8_t n_sd, modulo;
+   int bin;

gh = msgb_l3(msg);
pdisc = gsm48_hdr_pdisc(gh);

--
To view, visit https://gerrit.osmocom.org/11414
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

2018-10-21 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11414 )

Change subject: gsm0407_is_duplicate(): Handle error ret of 
gsm0407_pdisc_ctr_bin()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11414
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 21 Oct 2018 11:49:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

2018-10-21 Thread Harald Welte 
Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/11414


Change subject: gsm0407_is_duplicate(): Handle error ret of 
gsm0407_pdisc_ctr_bin()
..

gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Fixes: Coverity CID#182702
---
M src/libmsc/gsm_04_08.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/11414/1

diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 0f52d09..d5cc212 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1397,7 +1397,8 @@
 {
struct gsm48_hdr *gh;
uint8_t pdisc;
-   uint8_t n_sd, modulo, bin;
+   uint8_t n_sd, modulo;
+   int bin;

gh = msgb_l3(msg);
pdisc = gsm48_hdr_pdisc(gh);

--
To view, visit https://gerrit.osmocom.org/11414
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte