Change in osmo-msc[master]: msc_vlr_test_call: rename lu_utran_tmsi
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15952 ) Change subject: msc_vlr_test_call: rename lu_utran_tmsi .. msc_vlr_test_call: rename lu_utran_tmsi Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396 --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 16 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index dfa3141..339233c 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -43,7 +43,7 @@ #define IMSI "90170010650" -static void standard_lu() +static void lu_utran_tmsi() { struct vlr_subscr *vsub; @@ -173,7 +173,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector"); auth_request_sent = false; @@ -291,7 +291,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, MNCC asks us to setup a call, causing Paging"); @@ -394,7 +394,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, MNCC asks us to setup a call, causing Paging"); @@ -489,7 +489,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector"); auth_request_sent = false; @@ -585,7 +585,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector"); auth_request_sent = false; diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err index 07e10a5..8c394d0 100644 --- a/tests/msc_vlr/msc_vlr_test_call.err +++ b/tests/msc_vlr/msc_vlr_test_call.err @@ -189,11 +189,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + lu_utran_tmsi: now used by 2 (attached,lu_utran_tmsi) vsub != NULL == 1 strcmp(vsub->imsi, IMSI) == 0 LAC == 23 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - standard_lu: now used by 1 (attached) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - lu_utran_tmsi: now used by 1 (attached) - after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector @@ -663,11 +663,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + lu_utran_tmsi: now used by 2 (attached,lu_utran_tmsi) vsub != NULL == 1 strcmp(vsub->imsi, IMSI) == 0 LAC == 23 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - standard_lu: now used by 1 (attached) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - lu_utran_tmsi: now used by 1 (attached) - after a while, MNCC asks us to setup a call, causing Paging @@ -1134,11 +1134,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + lu_utran_tmsi: now used by 2 (attached,lu_utran_tmsi) vsub != NULL == 1 strcmp(vsub->imsi, IMSI) == 0 LAC == 23 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - standard_lu: now used by 1 (attached) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - lu_utran_tmsi: now used by 1 (attached) - after a while, MNCC asks us to setup a call, causing Paging @@ -1559,11 +1559,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF
Change in osmo-msc[master]: msc_vlr_test_call: rename lu_utran_tmsi
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15952 ) Change subject: msc_vlr_test_call: rename lu_utran_tmsi .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396 Gerrit-Change-Number: 15952 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 27 Nov 2019 09:23:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_vlr_test_call: rename lu_utran_tmsi
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15952 to look at the new patch set (#5). Change subject: msc_vlr_test_call: rename lu_utran_tmsi .. msc_vlr_test_call: rename lu_utran_tmsi Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396 --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/52/15952/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396 Gerrit-Change-Number: 15952 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: msc_vlr_test_call: rename lu_utran_tmsi
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15952 ) Change subject: msc_vlr_test_call: rename lu_utran_tmsi .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396 Gerrit-Change-Number: 15952 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 04 Nov 2019 10:44:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_vlr_test_call: rename lu_utran_tmsi
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15952 ) Change subject: msc_vlr_test_call: rename lu_utran_tmsi .. msc_vlr_test_call: rename lu_utran_tmsi Change-Id: I46a41321e6d1be3672a56a6e3cc36f013fdcd396 --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/52/15952/1 diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c index dfa3141..339233c 100644 --- a/tests/msc_vlr/msc_vlr_test_call.c +++ b/tests/msc_vlr/msc_vlr_test_call.c @@ -43,7 +43,7 @@ #define IMSI "90170010650" -static void standard_lu() +static void lu_utran_tmsi() { struct vlr_subscr *vsub; @@ -173,7 +173,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector"); auth_request_sent = false; @@ -291,7 +291,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, MNCC asks us to setup a call, causing Paging"); @@ -394,7 +394,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, MNCC asks us to setup a call, causing Paging"); @@ -489,7 +489,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector"); auth_request_sent = false; @@ -585,7 +585,7 @@ fake_time_start(); - standard_lu(); + lu_utran_tmsi(); BTW("after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector"); auth_request_sent = false; diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err index 07e10a5..8c394d0 100644 --- a/tests/msc_vlr/msc_vlr_test_call.err +++ b/tests/msc_vlr/msc_vlr_test_call.err @@ -189,11 +189,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + lu_utran_tmsi: now used by 2 (attached,lu_utran_tmsi) vsub != NULL == 1 strcmp(vsub->imsi, IMSI) == 0 LAC == 23 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - standard_lu: now used by 1 (attached) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - lu_utran_tmsi: now used by 1 (attached) - after a while, a new conn sends a CM Service Request. VLR responds with Auth Req, 2nd auth vector @@ -663,11 +663,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + lu_utran_tmsi: now used by 2 (attached,lu_utran_tmsi) vsub != NULL == 1 strcmp(vsub->imsi, IMSI) == 0 LAC == 23 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - standard_lu: now used by 1 (attached) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - lu_utran_tmsi: now used by 1 (attached) - after a while, MNCC asks us to setup a call, causing Paging @@ -1134,11 +1134,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + lu_utran_tmsi: now used by 2 (attached,lu_utran_tmsi) vsub != NULL == 1 strcmp(vsub->imsi, IMSI) == 0 LAC == 23 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - standard_lu: now used by 1 (attached) +DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 - lu_utran_tmsi: now used by 1 (attached) - after a while, MNCC asks us to setup a call, causing Paging @@ -1559,11 +1559,11 @@ DMSC msc_a(IMSI-90170010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:LU){MSC_A_ST_RELEASED}: Deallocated, including all deferred deallocations - msub gone llist_count(_list) == 0 -DREF VLR subscr IMSI-90170010650:MSISDN-42342:TMSI-0x03020100 + standard_lu: now used by 2 (attached,standard_lu) +DREF VLR subscr