Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 04 Nov 2019 10:09:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 04 Nov 2019 10:12:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/15851 )
Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify
..
rtp_stream: sanely cancel MGW endpoint FSM notify
libosmo-mgcp-client recently introduced osmo_mgcpc_ep_cancel_notify() to cancel
notification if a notify target FSM deallocates. Use it for sanity in
rtp_stream FSM cleanup, the notify target for endpoint FSMs.
Depends: I41687d7f3a808587ab7f7520f46dcc3c29cff92d (osmo-mgw)
I14f7a46031327fb2b2047b998eae6ad0bb7324ad (osmo-mgw)
Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015
---
M src/libmsc/rtp_stream.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c
index c3880bf..d78743e 100644
--- a/src/libmsc/rtp_stream.c
+++ b/src/libmsc/rtp_stream.c
@@ -220,6 +220,7 @@
{
struct rtp_stream *rtps = fi->priv;
if (rtps->ci) {
+ osmo_mgcpc_ep_cancel_notify(osmo_mgcpc_ep_ci_ep(rtps->ci), fi);
osmo_mgcpc_ep_ci_dlcx(rtps->ci);
rtps->ci = NULL;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015
Gerrit-Change-Number: 15851
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15851 to look at the new patch set (#2). Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. rtp_stream: sanely cancel MGW endpoint FSM notify libosmo-mgcp-client recently introduced osmo_mgcpc_ep_cancel_notify() to cancel notification if a notify target FSM deallocates. Use it for sanity in rtp_stream FSM cleanup, the notify target for endpoint FSMs. Depends: I41687d7f3a808587ab7f7520f46dcc3c29cff92d (osmo-mgw) I14f7a46031327fb2b2047b998eae6ad0bb7324ad (osmo-mgw) Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015 --- M src/libmsc/rtp_stream.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/51/15851/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 28 Oct 2019 19:36:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015 Gerrit-Change-Number: 15851 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 23 Oct 2019 13:57:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/15851 )
Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify
..
rtp_stream: sanely cancel MGW endpoint FSM notify
libosmo-mgcp-client recently introduced osmo_mgcpc_ep_cancel_notify() to cancel
notification if a notify target FSM deallocates. Use it for sanity in
rtp_stream FSM cleanup, the notify target for endpoint FSMs.
Depends: I41687d7f3a808587ab7f7520f46dcc3c29cff92d (osmo-mgw)
Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015
---
M src/libmsc/rtp_stream.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/51/15851/1
diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c
index c3880bf..d78743e 100644
--- a/src/libmsc/rtp_stream.c
+++ b/src/libmsc/rtp_stream.c
@@ -220,6 +220,7 @@
{
struct rtp_stream *rtps = fi->priv;
if (rtps->ci) {
+ osmo_mgcpc_ep_cancel_notify(osmo_mgcpc_ep_ci_ep(rtps->ci), fi);
osmo_mgcpc_ep_ci_dlcx(rtps->ci);
rtps->ci = NULL;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15851
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I351bb8e8fbc46eb629bcd599f6453e2c84c15015
Gerrit-Change-Number: 15851
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
