Change in osmo-pcu[master]: MCS: remove dead code

2019-03-04 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/13063 )

Change subject: MCS: remove dead code
..

MCS: remove dead code

As a preparation for (M)CS fixes in follow-up patches, remove unused
operators from GprsCodingScheme class.

Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
---
M src/gprs_coding_scheme.h
1 file changed, 0 insertions(+), 14 deletions(-)

Approvals:
  Holger Freyther: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 6087416..1acb14b 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -212,20 +212,6 @@
GprsCodingScheme::Scheme(a) < GprsCodingScheme::Scheme(b);
 }

-inline bool operator >(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return b < a;
-}
-
-inline bool operator <=(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return a == b || a < b;
-}
-
-inline bool operator >=(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return a == b || a > b;
-}
 inline GprsCodingScheme::Scheme GprsCodingScheme::get_retx_mcs(
const GprsCodingScheme mcs,
const GprsCodingScheme demanded_mcs,

--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol

Change in osmo-pcu[master]: MCS: remove dead code

2019-03-04 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13063 )

Change subject: MCS: remove dead code
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 04 Mar 2019 16:25:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: MCS: remove dead code

2019-03-03 Thread Holger Freyther 
Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/13063 )

Change subject: MCS: remove dead code
..


Patch Set 1: Code-Review+1

C++20 will bring you the spaceship operator 
(https://en.cppreference.com/w/cpp/language/default_comparisons) and ==/!=/<... 
will be autogenerated from it.

Apparently there are no tests for these.


--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 04 Mar 2019 06:24:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: MCS: remove dead code

2019-03-03 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/13063 )

Change subject: MCS: remove dead code
..


Patch Set 1:

Are you sure those are not being used? I'd leave them there in the event they 
are used, since I see you are leaving the opposite operator.


--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 03 Mar 2019 22:18:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-pcu[master]: MCS: remove dead code

2019-02-26 Thread Harald Welte 
Harald Welte has removed a vote on this change.

Change subject: MCS: remove dead code
..


Removed Code-Review+2 by Harald Welte 
--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-pcu[master]: MCS: remove dead code

2019-02-26 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13063


Change subject: MCS: remove dead code
..

MCS: remove dead code

As a preparation for (M)CS fixes in follow-up patches, remove unused
operators from GprsCodingScheme class.

Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
---
M src/gprs_coding_scheme.h
1 file changed, 0 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/63/13063/1

diff --git a/src/gprs_coding_scheme.h b/src/gprs_coding_scheme.h
index 76cab0f..ee30c8a 100644
--- a/src/gprs_coding_scheme.h
+++ b/src/gprs_coding_scheme.h
@@ -220,20 +220,6 @@
GprsCodingScheme::Scheme(a) < GprsCodingScheme::Scheme(b);
 }

-inline bool operator >(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return b < a;
-}
-
-inline bool operator <=(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return a == b || a < b;
-}
-
-inline bool operator >=(GprsCodingScheme a, GprsCodingScheme b)
-{
-   return a == b || a > b;
-}
 inline GprsCodingScheme::Scheme GprsCodingScheme::get_retx_mcs(
const GprsCodingScheme mcs,
const GprsCodingScheme demanded_mcs,

--
To view, visit https://gerrit.osmocom.org/13063
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieef3b095a6732300e5efa395b989843112b9ca78
Gerrit-Change-Number: 13063
Gerrit-PatchSet: 1
Gerrit-Owner: Max