Change in osmo-pcu[master]: Remove custom alarms
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13360 ) Change subject: Remove custom alarms .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c File src/osmo-bts-oc2g/oc2g_l1_if.c: https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c@a236 PS1, Line 236: > If those signals are not used, what about removing the enums? Or they don't > exist in our tree? They were in a commit that I didn't cherry-pick so they don't exist in our code base -- To view, visit https://gerrit.osmocom.org/13360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51de826aa732a3875d75396b46b7d2821ef7417c Gerrit-Change-Number: 13360 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Mon, 25 Mar 2019 14:40:55 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: Remove custom alarms
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13360 ) Change subject: Remove custom alarms .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51de826aa732a3875d75396b46b7d2821ef7417c Gerrit-Change-Number: 13360 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 15:44:31 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-pcu[master]: Remove custom alarms
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13360 ) Change subject: Remove custom alarms .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c File src/osmo-bts-oc2g/oc2g_l1_if.c: https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c@a236 PS1, Line 236: If those signals are not used, what about removing the enums? Or they don't exist in our tree? -- To view, visit https://gerrit.osmocom.org/13360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51de826aa732a3875d75396b46b7d2821ef7417c Gerrit-Change-Number: 13360 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Willmann Gerrit-Reviewer: Jenkins Builder (102) Gerrit-CC: Pau Espin Pedrol Gerrit-Comment-Date: Thu, 21 Mar 2019 15:02:30 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-pcu[master]: Remove custom alarms
Daniel Willmann has uploaded this change for review. (
https://gerrit.osmocom.org/13360
Change subject: Remove custom alarms
..
Remove custom alarms
Change-Id: I51de826aa732a3875d75396b46b7d2821ef7417c
---
M src/osmo-bts-oc2g/oc2g_l1_if.c
1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/13360/1
diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c
index 80b9dbc..f9768ae 100644
--- a/src/osmo-bts-oc2g/oc2g_l1_if.c
+++ b/src/osmo-bts-oc2g/oc2g_l1_if.c
@@ -232,9 +232,6 @@
default:
LOGP(DL1IF, LOGL_NOTICE, "Rx PH-DATA.ind for unknown L1 SAPI
%s\n",
get_value_string(oc2gbts_l1sapi_names, data_ind->sapi));
- memcpy(alarm_sig_data.spare, &data_ind->sapi, sizeof(unsigned
int));
- osmo_signal_dispatch(SS_L_GLOBAL,
S_PCU_NM_RX_UNKN_L1_SAP_ALARM, &alarm_sig_data);
-
break;
}
@@ -286,7 +283,6 @@
rc = handle_ph_ra_ind(fl1h, &l1p->u.phRaInd);
break;
default:
- osmo_signal_dispatch(SS_L_GLOBAL,
S_PCU_NM_RX_UNKN_L1_PRIM_ALARM, &alarm_sig_data);
break;
}
@@ -340,7 +336,6 @@
/* transmit */
if (osmo_wqueue_enqueue(&fl1h->write_q[MQ_PDTCH_WRITE], msg) != 0) {
LOGP(DL1IF, LOGL_ERROR, "PDTCH queue full. dropping
message.\n");
- osmo_signal_dispatch(SS_L_GLOBAL,
S_PCU_NM_PDTCH_QUEUE_FULL_ALARM, &alarm_sig_data);
msgb_free(msg);
}
@@ -365,8 +360,6 @@
rc = l1if_transport_open(MQ_PDTCH_WRITE, fl1h);
if (rc < 0) {
- alarm_sig_data.spare[0] = trx_no;
- osmo_signal_dispatch(SS_L_GLOBAL, S_PCU_NM_FAIL_OPEN_L1_ALARM,
&alarm_sig_data);
talloc_free(fl1h);
return NULL;
}
--
To view, visit https://gerrit.osmocom.org/13360
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51de826aa732a3875d75396b46b7d2821ef7417c
Gerrit-Change-Number: 13360
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Willmann
