Change in osmo-sgsn[master]: Port gbproxy to NS2
daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok M tests/vty_test_runner.py 10 files changed, 3,325 insertions(+), 4,991 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 6 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-sgsn[master]: Port gbproxy to NS2
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 6 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 21:07:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 6 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 17:45:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 to look at the new patch set (#6). Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok M tests/vty_test_runner.py 10 files changed, 3,325 insertions(+), 4,991 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/21029/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 6 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: Port gbproxy to NS2
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 15:55:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 to look at the new patch set (#5). Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok M tests/vty_test_runner.py 10 files changed, 3,325 insertions(+), 4,976 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/21029/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: Port gbproxy to NS2
Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 to look at the new patch set (#4). Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 9 files changed, 3,319 insertions(+), 4,970 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/21029/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: Port gbproxy to NS2
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 12:54:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
Hello Jenkins Builder, laforge, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 to look at the new patch set (#3). Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 8 files changed, 3,316 insertions(+), 4,969 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/21029/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: Port gbproxy to NS2
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 10:26:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 04 Nov 2020 10:23:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 to look at the new patch set (#2). Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 8 files changed, 3,316 insertions(+), 4,971 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/21029/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: Port gbproxy to NS2
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 )
Change subject: Port gbproxy to NS2
..
Patch Set 1:
(11 comments)
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/include/osmocom/sgsn/gb_proxy.h
File include/osmocom/sgsn/gb_proxy.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/include/osmocom/sgsn/gb_proxy.h@249
PS1, Line 249: //int gbprox_reset_persistent_nsvcs(struct gprs_ns2_inst *nsi);
> what about this?
Removed it, should be configurable in config with:
encapsulation udp use-reset-block-unblock enabled
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c
File src/gbproxy/gb_proxy.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@80
PS1, Line 80:uint16_t ns_bvci);
> unrelated whitespace fix, can be done separately.
Ack
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@807
PS1, Line 807: uint16_t ns_bvci)
> unrelated ws fix
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@1221
PS1, Line 1221: /* simple case: BVCI IE is mandatory */
> This block looks like a separate patch.
Ack
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@1379
PS1, Line 1379: //int gbprox_reset_persistent_nsvcs(struct gprs_ns_inst *nsi)
> what about this
Yeah, handled by ns2 now. Removed it
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@1445
PS1, Line 1445: void gprs_ns_prim_status_cb(struct gbproxy_config *cfg, struct
osmo_gprs_ns2_prim *nsp)
> Move this above gprs_ns_prim_cb then you can drop forward declaration.
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_ctrl.c
File src/gbproxy/gb_proxy_ctrl.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_ctrl.c@37
PS1, Line 37: //static int get_nsvc_state(struct ctrl_cmd *cmd, void *data)
> So what do we do here? we wait until it is supported in ns2?
Yeah, I'm working on adding support back in. I implemented the parts that are
already there.
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_main.c
File src/gbproxy/gb_proxy_main.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_main.c@84
PS1, Line 84: //static int proxy_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc
*nsvc,
> what about this
Thanks, not removed it as it relates to the old ns code
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_main.c@372
PS1, Line 372: // rc = gprs_ns_nsip_listen(bssgp_nsi);
> what about his
Removed, thanks. Handled by the bind config
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_vty.c
File src/gbproxy/gb_proxy_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_vty.c@683
PS1, Line 683: // llist_for_each_entry_safe(nsvc, nsvc2,
&nsi->gprs_nsvcs, list) {
> what about this
I kept the todo about not deleting persistent NSVC for the future and also
fixed the dry_run logic but otherwise removed the loop
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/tests/gbproxy/gbproxy_test.c
File tests/gbproxy/gbproxy_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/tests/gbproxy/gbproxy_test.c@36
PS1, Line 36:
> Drop ws
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524
Gerrit-Change-Number: 21029
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Nov 2020 20:35:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 )
Change subject: Port gbproxy to NS2
..
Patch Set 1:
(11 comments)
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/include/osmocom/sgsn/gb_proxy.h
File include/osmocom/sgsn/gb_proxy.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/include/osmocom/sgsn/gb_proxy.h@249
PS1, Line 249: //int gbprox_reset_persistent_nsvcs(struct gprs_ns2_inst *nsi);
what about this?
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c
File src/gbproxy/gb_proxy.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@80
PS1, Line 80:uint16_t ns_bvci);
unrelated whitespace fix, can be done separately.
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@807
PS1, Line 807: uint16_t ns_bvci)
unrelated ws fix
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@1221
PS1, Line 1221: /* simple case: BVCI IE is mandatory */
This block looks like a separate patch.
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@1379
PS1, Line 1379: //int gbprox_reset_persistent_nsvcs(struct gprs_ns_inst *nsi)
what about this
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy.c@1445
PS1, Line 1445: void gprs_ns_prim_status_cb(struct gbproxy_config *cfg, struct
osmo_gprs_ns2_prim *nsp)
Move this above gprs_ns_prim_cb then you can drop forward declaration.
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_ctrl.c
File src/gbproxy/gb_proxy_ctrl.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_ctrl.c@37
PS1, Line 37: //static int get_nsvc_state(struct ctrl_cmd *cmd, void *data)
So what do we do here? we wait until it is supported in ns2?
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_main.c
File src/gbproxy/gb_proxy_main.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_main.c@84
PS1, Line 84: //static int proxy_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc
*nsvc,
what about this
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_main.c@372
PS1, Line 372: // rc = gprs_ns_nsip_listen(bssgp_nsi);
what about his
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_vty.c
File src/gbproxy/gb_proxy_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/src/gbproxy/gb_proxy_vty.c@683
PS1, Line 683: // llist_for_each_entry_safe(nsvc, nsvc2,
&nsi->gprs_nsvcs, list) {
what about this
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/tests/gbproxy/gbproxy_test.c
File tests/gbproxy/gbproxy_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21029/1/tests/gbproxy/gbproxy_test.c@36
PS1, Line 36:
Drop ws
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524
Gerrit-Change-Number: 21029
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Nov 2020 10:30:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 ) Change subject: Port gbproxy to NS2 .. Patch Set 1: Depends-on: Ifa769bce920a08cf93553dcb164a3fcf50162517 (libosmocore.git) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 03 Nov 2020 09:24:06 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Port gbproxy to NS2
Hello lynxis lazus, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 to review the following change. Change subject: Port gbproxy to NS2 .. Port gbproxy to NS2 Since NS2 has a different abstraction we mock up the prim send/recv functions and don't test NS like the old tests did. Related: SYS#4998 Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 --- M include/osmocom/sgsn/gb_proxy.h M src/gbproxy/gb_proxy.c M src/gbproxy/gb_proxy_ctrl.c M src/gbproxy/gb_proxy_main.c M src/gbproxy/gb_proxy_patch.c M src/gbproxy/gb_proxy_vty.c M tests/gbproxy/gbproxy_test.c M tests/gbproxy/gbproxy_test.ok 8 files changed, 3,379 insertions(+), 4,940 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/29/21029/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iecfd0408a35a11638d254c1db3c1d477b1a11524 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newchange
