Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 ) Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a Gerrit-Change-Number: 21030 Gerrit-PatchSet: 7 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 21:33:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
daniel has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 )
Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC
..
gbproxy: Get the peer if paging by BVCI on SIG_BVC
Currently the code reports routing the message to a BVCI but never even
tries to get the peer for it.
Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a
Related: SYS#4998
---
M src/gbproxy/gb_proxy.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index e8a81e7..ccf3f73 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1105,6 +1105,7 @@
nsei);
if (TLVP_PRESENT(tp, BSSGP_IE_BVCI)) {
uint16_t bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
+ peer = gbproxy_peer_by_bvci(cfg, bvci);
LOGPC(DGPRS, LOGL_INFO, "routing by BVCI to peer BVCI=%u\n",
bvci);
errctr = GBPROX_GLOB_CTR_OTHER_ERR;
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a
Gerrit-Change-Number: 21030
Gerrit-PatchSet: 7
Gerrit-Owner: daniel
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 ) Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a Gerrit-Change-Number: 21030 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 12:53:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 to look at the new patch set (#3). Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC .. gbproxy: Get the peer if paging by BVCI on SIG_BVC Currently the code reports routing the message to a BVCI but never even tries to get the peer for it. Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a Related: SYS#4998 --- M src/gbproxy/gb_proxy.c M tests/gbproxy/gbproxy_test.ok 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/30/21030/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a Gerrit-Change-Number: 21030 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 ) Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a Gerrit-Change-Number: 21030 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 06 Nov 2020 10:29:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 ) Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a Gerrit-Change-Number: 21030 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 03 Nov 2020 22:48:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy: Get the peer if paging by BVCI on SIG_BVC
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21030 )
Change subject: gbproxy: Get the peer if paging by BVCI on SIG_BVC
..
gbproxy: Get the peer if paging by BVCI on SIG_BVC
Currently the code reports routing the message to a BVCI but never even
tries to get the peer for it.
Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a
Related: SYS#4998
---
M src/gbproxy/gb_proxy.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/30/21030/1
diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 5c1c96e..ddb7342 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1105,6 +1105,7 @@
nsei);
if (TLVP_PRESENT(tp, BSSGP_IE_BVCI)) {
uint16_t bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
+ peer = gbproxy_peer_by_bvci(cfg, bvci);
LOGPC(DGPRS, LOGL_INFO, "routing by BVCI to peer BVCI=%u\n",
bvci);
errctr = GBPROX_GLOB_CTR_OTHER_ERR;
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21030
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic72f0f03e5886ab76404915fc60a2796e6881a7a
Gerrit-Change-Number: 21030
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
