Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

2020-12-02 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )


Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without 
mandatory IEs
..

gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
---
M src/gbproxy/gb_proxy.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/77/21477/1

diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 2c63614..109a539 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1017,8 +1017,10 @@
uint16_t bvci;
uint8_t cause;

-   if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI) || !TLVP_PRESENT(tp, 
BSSGP_IE_CAUSE))
-   return 0;
+   if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI) || !TLVP_PRESENT(tp, 
BSSGP_IE_CAUSE)) {
+   rate_ctr_inc(&cfg->ctrg->ctr[GBPROX_GLOB_CTR_PROTO_ERR_BSS]);
+   return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
+   }

bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
cause = *TLVP_VAL(tp, BSSGP_IE_CAUSE);

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange

Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

2020-12-03 Thread daniel 
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )

Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without 
mandatory IEs
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Thu, 03 Dec 2020 12:19:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

2020-12-03 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )

Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without 
mandatory IEs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 03 Dec 2020 13:02:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

2020-12-05 Thread laforge 
Hello Jenkins Builder, pespin, daniel,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sgsn/+/21477

to look at the new patch set (#3).

Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without 
mandatory IEs
..

gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
---
M src/gbproxy/gb_proxy.c
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/77/21477/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

2020-12-05 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )

Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without 
mandatory IEs
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Sat, 05 Dec 2020 10:52:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

2020-12-05 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )

Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without 
mandatory IEs
..

gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
---
M src/gbproxy/gb_proxy.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index a4ad7af..8b103c8 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1017,8 +1017,10 @@
struct gbproxy_peer *from_peer = NULL;
uint16_t bvci;

-   if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI))
-   return 0;
+   if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI) || !TLVP_PRESENT(tp, 
BSSGP_IE_CAUSE)) {
+   rate_ctr_inc(&cfg->ctrg->ctr[GBPROX_GLOB_CTR_PROTO_ERR_BSS]);
+   return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
+   }

bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
LOGP(DGPRS, LOGL_INFO, "NSE(%05u) Rx BVC RESET (BVCI=%05u)\n", nsei, 
bvci);

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged