Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

2018-12-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12286 )

Change subject: Introduce systemd service file and install with autotools
..


Patch Set 2:

> Is it enabled by default in OE? If so than it might interfere with
 > normal testing/use so I propose to abandon this altogether or move
 > to WIP until we actually have the hypothetical use case described
 > by Pau.

It's easy to configur the recipe to not enable the systemd file in OE, but 
fine, let's keep it out for now.


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:02:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

2018-12-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )

Change subject: Introduce systemd service file and install with autotools
..


Patch Set 2: Code-Review-1

Is it enabled by default in OE? If so than it might interfere with normal 
testing/use so I propose to abandon this altogether or move to WIP until we 
actually have the hypothetical use case described by Pau.


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 15:12:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

2018-12-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12286 )

Change subject: Introduce systemd service file and install with autotools
..


Patch Set 2: Code-Review-1

I don't think a systemd service is going to be useful at this point, it would 
probably just be misleading to the user.


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:44:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

2018-12-13 Thread Pau Espin Pedrol
Hello Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12286

to look at the new patch set (#2).

Change subject: Introduce systemd service file and install with autotools
..

Introduce systemd service file and install with autotools

Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
A contrib/systemd/osmo-sysmon.service
5 files changed, 41 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/86/12286/2
--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol