Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/10717 ) Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp Fixes compilation warning: In file included from osmo-trx/Transceiver52M/device/uhd/UHDDevice.cpp:31: /usr/include/uhd/utils/thread_priority.hpp:10:17: note: #pragma message: This header is deprecated - please use instead. Header was moved in uhd.git c33928d2bbdd27688c3475e77fc461e7d16eba5a. Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe --- M Transceiver52M/device/uhd/UHDDevice.cpp 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp index 63d3dec..b7109a4 100644 --- a/Transceiver52M/device/uhd/UHDDevice.cpp +++ b/Transceiver52M/device/uhd/UHDDevice.cpp @@ -28,7 +28,6 @@ #include #include #include -#include #ifdef HAVE_CONFIG_H #include "config.h" @@ -36,6 +35,9 @@ #ifndef USE_UHD_3_11 #include +#include +#else +#include #endif #define USRP_TX_AMPL 0.3 -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol
Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10717 ) Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Mon, 10 Sep 2018 14:59:18 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10717 ) Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. Patch Set 2: > I saw this warning, too. The question is: When was that moved? > What kind of compatibility to old UHD versions are we dropping with > your proposed patch? With 2nd version of this patch I already posted we don't loose compatibility, since old version will continue to use thread_priority.hpp. -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Harald Welte Gerrit-Comment-Date: Fri, 07 Sep 2018 17:55:58 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10717 ) Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. Patch Set 2: I saw this warning, too. The question is: When was that moved? What kind of compatibility to old UHD versions are we dropping with your proposed patch? -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-CC: Harald Welte Gerrit-Comment-Date: Fri, 07 Sep 2018 16:42:32 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10717 ) Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 07 Sep 2018 12:28:19 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10717 ) Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. Patch Set 1: Didn't test this batch of patches yes, wrote them during my flight. -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Comment-Date: Fri, 31 Aug 2018 09:54:41 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-trx[master]: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10717 Change subject: UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp .. UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp Fixes compilation warning: In file included from osmo-trx/Transceiver52M/device/uhd/UHDDevice.cpp:31: /usr/include/uhd/utils/thread_priority.hpp:10:17: note: #pragma message: This header is deprecated - please use instead. Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe --- M Transceiver52M/device/uhd/UHDDevice.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/17/10717/1 diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp index 63d3dec..a9ae19a 100644 --- a/Transceiver52M/device/uhd/UHDDevice.cpp +++ b/Transceiver52M/device/uhd/UHDDevice.cpp @@ -28,7 +28,7 @@ #include #include #include -#include +#include #ifdef HAVE_CONFIG_H #include "config.h" -- To view, visit https://gerrit.osmocom.org/10717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6299df48a5e14c54eaa07288d166c705eb9ebdbe Gerrit-Change-Number: 10717 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
