Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. BSC_Tests: expect a HANDOVER PERFORMED message on internal handover When an internal handover is performed, the BSC is expected to inform the MSC about the event by sending a BSSMAP HANDOVER PERFORMED message. This feature was missing in the BSC and has now been added. The tests need to be upgraded in order to handle the additional message. - Upgrade f_tc_ho_int so that it expects a HANDOVER PERFORMED message Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Depends: osmo-bsc If26e5807280e0f75a423b3b04f8e3c698c82a351 Related: OS#3645 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Neels Hofmeyr: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 81cf23e..aaa4580 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2256,6 +2256,10 @@ [] as_handover(hs); } + /* Since this is an internal handover we expect the BSC to inform the +* MSC about the event */ + BSSAP.receive(tr_BSSMAP_HandoverPerformed); + /* Check the amount of MGCP transactions is still consistant with the * test expectation */ f_check_mgcp_expectations() -- To view, visit https://gerrit.osmocom.org/11733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: dexter
Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11733 Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. BSC_Tests: expect a HANDOVER PERFORMED message on internal handover When an internal handover is performed, the BSC is expected to inform the MSC about the event by sending a BSSMAP HANDOVER PERFORMED message. This feature was missing in the BSC and has now been added. The tests need to be upgraded in order to handle the additional message. - Upgrade f_tc_ho_int so that it expects a HANDOVER PERFORMED message Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Depends: osmo-bsc If26e5807280e0f75a423b3b04f8e3c698c82a351 Related: OS#3645 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/11733/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e3ac707..1fc73ef 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2187,6 +2187,10 @@ [] as_handover(hs); } + /* Since this is an internal handover we expect the BSC to inform the +* MSC about the event */ + BSSAP.receive(tr_BSSMAP_HandoverPerformed); + /* Check the amount of MGCP transactions is still consistant with the * test expectation */ f_check_mgcp_expectations() -- To view, visit https://gerrit.osmocom.org/11733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter
Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11733/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/11733/1/bsc/BSC_Tests.ttcn@2192 PS1, Line 2192: BSSAP.receive(tr_BSSMAP_HandoverPerformed); will we *always* send a handover performed, or only when the codec changed? IIUC the MSC need not be bothered with it if the RTP remains identical. -- To view, visit https://gerrit.osmocom.org/11733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Comment-Date: Mon, 12 Nov 2018 17:16:51 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. Patch Set 1: > (1 comment) 3GPP TS 48.008 says 3.2.1.25 "This message is sent from the BSS to the MSC in order to indicate that the BSS has performed an internal handover." I suspect that this may be somehow related to location based services. -- To view, visit https://gerrit.osmocom.org/11733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: dexter Gerrit-Comment-Date: Tue, 13 Nov 2018 12:21:22 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: dexter Gerrit-Comment-Date: Sun, 18 Nov 2018 20:34:40 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/11733 )
Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal
handover
..
Patch Set 3:
let's see...
OK you're right. The spec says that during Assignment we send no HANDOVER
PERFORMED message (duh!), but even during a handover within the same cell (not
even changing the BTS), we actually *do* send a HANDOVER PERFORMED message:
48.008 3.1.1.1 (Assignment / success)
"If an intra-BSS cell change has
occurred during the assignment, the new cell identity is included in the
ASSIGNMENT COMPLETE message and a
HANDOVER PERFORMED message is not required."
3.1.6 Internal Intra-Cell Handover Procedure
and same at
3.1.7 Internal Inter-Cell Handover Procedure
Internal {intra,inter}-cell handover [...] is decided and executed autonomously
by the
BSS, so that no message is generated at the BSS-MSC interface, until the
completion of the handover execution, when
the BSS sends a HANDOVER PERFORMED message over the SCCP and terrestrial
resources that are presently
assigned to that call. Changes in type of resources (for instance channel rate
change, speech version change, ciphering
algorithm change) are indicated in the HANDOVER PERFORMED message.
--
To view, visit https://gerrit.osmocom.org/11733
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7
Gerrit-Change-Number: 11733
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: dexter
Gerrit-Comment-Date: Mon, 19 Nov 2018 16:21:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: No
