Change in osmo-ttcn3-hacks[master]: BSC_Tests: use consistant AMR S0-S15 bits
dexter has submitted this change and it was merged. (
https://gerrit.osmocom.org/11131 )
Change subject: BSC_Tests: use consistant AMR S0-S15 bits
..
BSC_Tests: use consistant AMR S0-S15 bits
At the moment we use the default S0-S15 bits for the AMR config,
regardless what RSL_IE_Body mr_conf or osmo-bsc.cfg sets.
- Make sure consistant S0-S15 bits are used for AMR related tests.
This is a re-submit of change I794e6d4fe8abc67337428cbe0bcc8802fae37a6e,
which had to be reverted because the depending patch in osmo-bsc is not
yet merged into master. This caused TC_assignment_codec_amr_f and
TC_assignment_codec_amr_h to fail.
Change-Id: Ia98f18ba2c17c85ed01488734dc6df67f5b60d41
Depends: osmo-bsc: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Related: OS#3529
---
M bsc/BSC_Tests.ttcn
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 25df52d..4a34310 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1923,6 +1923,10 @@
testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* Note: This setups the codec configuration. The parameter payload in
+* mr_conf must be consistant with the parameter codecElements in pars
+* and also must match the amr-config in osmo-bsc.cfg! */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1930,11 +1934,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
@@ -1942,6 +1949,8 @@
testcase TC_assignment_codec_amr_h() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* See note above */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1949,11 +1958,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
--
To view, visit https://gerrit.osmocom.org/11131
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia98f18ba2c17c85ed01488734dc6df67f5b60d41
Gerrit-Change-Number: 11131
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: dexter
Change in osmo-ttcn3-hacks[master]: BSC_Tests: use consistant AMR S0-S15 bits
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11131
Change subject: BSC_Tests: use consistant AMR S0-S15 bits
..
BSC_Tests: use consistant AMR S0-S15 bits
At the moment we use the default S0-S15 bits for the AMR config,
regardless what RSL_IE_Body mr_conf or osmo-bsc.cfg sets.
- Make sure consistant S0-S15 bits are used for AMR related tests.
This is a re-submit of change I794e6d4fe8abc67337428cbe0bcc8802fae37a6e,
which had to be reverted because the depending patch in osmo-bsc is not
yet merged into master. This caused TC_assignment_codec_amr_f and
TC_assignment_codec_amr_h to fail.
Change-Id: Ia98f18ba2c17c85ed01488734dc6df67f5b60d41
Depends: osmo-bsc: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737
Related: OS#3529
---
M bsc/BSC_Tests.ttcn
1 file changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/31/11131/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 25df52d..4a34310 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1923,6 +1923,10 @@
testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* Note: This setups the codec configuration. The parameter payload in
+* mr_conf must be consistant with the parameter codecElements in pars
+* and also must match the amr-config in osmo-bsc.cfg! */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1930,11 +1934,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
@@ -1942,6 +1949,8 @@
testcase TC_assignment_codec_amr_h() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* See note above */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1949,11 +1958,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
--
To view, visit https://gerrit.osmocom.org/11131
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia98f18ba2c17c85ed01488734dc6df67f5b60d41
Gerrit-Change-Number: 11131
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Change in osmo-ttcn3-hacks[master]: BSC_Tests: use consistant AMR S0-S15 bits
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11055 )
Change subject: BSC_Tests: use consistant AMR S0-S15 bits
..
BSC_Tests: use consistant AMR S0-S15 bits
At the moment we use the default S0-S15 bits for the AMR config,
regardless what RSL_IE_Body mr_conf or osmo-bsc.cfg sets.
- Make sure consistant S0-S15 bits are used for AMR related tests.
Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e
---
M bsc/BSC_Tests.ttcn
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a99214b..9a43ead 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1905,6 +1905,10 @@
testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* Note: This setups the codec configuration. The parameter payload in
+* mr_conf must be consistant with the parameter codecElements in pars
+* and also must match the amr-config in osmo-bsc.cfg! */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1912,11 +1916,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
@@ -1924,6 +1931,8 @@
testcase TC_assignment_codec_amr_h() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* See note above */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1931,11 +1940,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
--
To view, visit https://gerrit.osmocom.org/11055
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e
Gerrit-Change-Number: 11055
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-ttcn3-hacks[master]: BSC_Tests: use consistant AMR S0-S15 bits
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11055 ) Change subject: BSC_Tests: use consistant AMR S0-S15 bits .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e Gerrit-Change-Number: 11055 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Sat, 22 Sep 2018 11:35:53 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: BSC_Tests: use consistant AMR S0-S15 bits
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11055
Change subject: BSC_Tests: use consistant AMR S0-S15 bits
..
BSC_Tests: use consistant AMR S0-S15 bits
At the moment we use the default S0-S15 bits for the AMR config,
regardless what RSL_IE_Body mr_conf or osmo-bsc.cfg sets.
- Make sure consistant S0-S15 bits are used for AMR related tests.
Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e
---
M bsc/BSC_Tests.ttcn
1 file changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/55/11055/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a99214b..9a43ead 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1905,6 +1905,10 @@
testcase TC_assignment_codec_amr_f() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* Note: This setups the codec configuration. The parameter payload in
+* mr_conf must be consistant with the parameter codecElements in pars
+* and also must match the amr-config in osmo-bsc.cfg! */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1912,11 +1916,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '01010111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
@@ -1924,6 +1931,8 @@
testcase TC_assignment_codec_amr_h() runs on test_CT {
var TestHdlrParams pars := valueof(t_def_TestHdlrPars);
var MSC_ConnHdlr vc_conn;
+
+ /* See note above */
var RSL_IE_Body mr_conf := {
other := {
len := 2,
@@ -1931,11 +1940,14 @@
}
};
+ pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
+ pars.ass_codec_list.codecElements[0].s0_7 := '0110'B;
+ pars.ass_codec_list.codecElements[0].s8_15 := '0111'B;
+ pars.expect_mr_conf_ie := mr_conf;
+
f_init(1, true);
f_sleep(1.0);
- pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_H}));
- pars.expect_mr_conf_ie := mr_conf;
vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars);
vc_conn.done;
}
--
To view, visit https://gerrit.osmocom.org/11055
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I794e6d4fe8abc67337428cbe0bcc8802fae37a6e
Gerrit-Change-Number: 11055
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
