Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Max has abandoned this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Abandoned -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Comment-Date: Mon, 07 Jan 2019 16:02:50 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: Then perhaps the best course of action is to just leave things as they are? -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Comment-Date: Wed, 19 Dec 2018 14:31:43 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Max has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: > Patch Set 1: Code-Review+1 > Simply changing the log level of this message in osmo-msc might be fine > indeed. I'm kinda partial about it: the main reason we see lots of those in TTCN tests is that we don't really have HLR but some GSUP emulation code which is called when necessary. That's why the link appears to be flapping: each test causes it to go UP/DOWN at least once (maybe more), and the number of tests will only increase. In the normal case where you have actual HLR up and running you'd see this message once. Unless smth is wrong with HLR or link to it but in this case you'll want to see this message, not suppress it. -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Comment-Date: Tue, 18 Dec 2018 18:02:53 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Stefan Sperling has removed a vote on this change. Change subject: MSC: adjust gsup log level to error .. Removed Code-Review+1 by Stefan Sperling -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: Code-Review+1 > Patch Set 1: > > I am not sure if this is a very good idea. Shouldn't the integration tests > log as much as possible to allow investigation afterwards. What if there is a > bug hiding in the gsub code? > > Maybe we should try to find a more reasonable logging level for the related > GSUP logging in osmo-msc? I agree that the message is annoying, I also see it a lot: Tue Dec 18 18:45:47 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:47 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:48 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:48 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:49 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:49 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:50 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:50 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:51 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:51 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:52 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:52 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:53 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:53 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:54 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:54 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Simply changing the log level of this message in osmo-msc might be fine indeed. -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Comment-Date: Tue, 18 Dec 2018 17:46:34 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
dexter has posted comments on this change. ( https://gerrit.osmocom.org/12298 ) Change subject: MSC: adjust gsup log level to error .. Patch Set 1: I am not sure if this is a very good idea. Shouldn't the integration tests log as much as possible to allow investigation afterwards. What if there is a bug hiding in the gsub code? Maybe we should try to find a more reasonable logging level for the related GSUP logging in osmo-msc? -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Comment-Date: Tue, 18 Dec 2018 09:31:24 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12298 Change subject: MSC: adjust gsup log level to error .. MSC: adjust gsup log level to error The HLR emulation is active only for short time during each test so we got lots of useless "gsup_client.c:73 GSUP connecting to 127.0.0.1:4222" messages due to continuous attempts to reconnect to HLR. Let's use error log level to obtain relevant errors (if any). Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c --- M msc/osmo-msc.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/12298/1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index ddac4cd..79d509e 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -34,7 +34,7 @@ logging level lctrl info logging level lgtp notice logging level lstats notice - logging level lgsup notice + logging level lgsup error logging level loap notice logging level lss7 notice logging level lsccp notice -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max
