Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-10 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 )

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..

NS_Tests: add test case TC_sns_bss_add_change_del

1. do SNS configuration
2. add a bind
3. receive the SNS_ADD
4. before answering the SNS_ADD, change the weight via vty and remove the bind

Related: OS#5036
Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
---
M ns/NS_Tests.ttcn
1 file changed, 47 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 3971f0d..8bbb43c 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -580,6 +580,52 @@
f_clean_ns_codec();
 }

+/* 1. do SNS configuration
+ * 2. add a bind
+ * 3. receive the SNS_ADD
+ * 4. before answering the SNS_ADD, change the weight via vty and remove the 
bind
+ */
+testcase TC_sns_bss_add_change_del() runs on RAW_Test_CT {
+   var PDU_NS rx;
+   var NSVCConfiguration nsvc_cfg;
+
+   g_handle_rx_alive := true;
+   f_init_vty();
+   f_init_ns_codec(mp_nsconfig);
+   f_init_ns_codec(mp_nsconfig, 1);
+   f_incoming_sns_size();
+   f_incoming_sns_config();
+   f_outgoing_sns_config();
+   activate(as_rx_alive_tx_ack());
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, 
"ip-sns-bind local2");
+
+   /* rx SNS ADD */
+   nsvc_cfg := g_nsconfig.nsvc[1];
+   if (nsvc_cfg.provider.ip.address_family == AF_INET) {
+   var template (omit) IP4_Elements v4_elem := { 
ts_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+1, 1) };
+   rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, v4 := v4_elem), 
0);
+   } else {
+   var template (omit) IP6_Elements v6_elem := { 
ts_SNS_IPv6(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+1, 1) };
+   rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, omit, v6_elem), 
0);
+   }
+
+   /* delete the endpoint */
+   f_vty_config2(NSVTY, {"ns", "bind udp local2"}, "ip-sns 
signalling-weight 99 data-weight 99");
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, "no 
ip-sns-bind local2");
+
+   /* accept the SNS_ADD */
+   NSCP[0].send(ts_SNS_ACK(g_nsconfig.nsei, rx.pDU_SNS_Add.transactionID));
+
+   f_incoming_sns_chg_weight(idx_chg := 1);
+   f_incoming_sns_del(idx_del := 1, w_sig := 99, w_user := 99);
+   setverdict(pass);
+   f_clean_ns_codec();
+}
+
 control {
if (mp_dialect == NS2_DIALECT_STATIC_RESETBLOCK or mp_dialect == 
NS2_DIALECT_IPACCESS) {
execute( TC_tx_reset() );
@@ -629,6 +675,7 @@
execute( TC_sns_bss_change_weight_timeout() );
execute( TC_sns_bss_add() );
execute( TC_sns_bss_del() );
+   execute( TC_sns_bss_add_change_del() );
}
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-10 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 )

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 10 Jun 2021 12:47:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-07 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 )

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 12:49:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-07 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 )

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 09:23:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-06 Thread lynxis lazus
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580

to look at the new patch set (#4).

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..

NS_Tests: add test case TC_sns_bss_add_change_del

1. do SNS configuration
2. add a bind
3. receive the SNS_ADD
4. before answering the SNS_ADD, change the weight via vty and remove the bind

Related: OS#5036
Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
---
M ns/NS_Tests.ttcn
1 file changed, 47 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/80/24580/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-06 Thread lynxis lazus
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580

to look at the new patch set (#3).

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..

NS_Tests: add test case TC_sns_bss_add_change_del

1. do SNS configuration
2. add a bind
3. receive the SNS_ADD
4. before answering the SNS_ADD, change the weight via vty and remove the bind

Related: OS#5036
Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
---
M ns/NS_Tests.ttcn
1 file changed, 45 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/80/24580/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-06 Thread lynxis lazus
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580

to look at the new patch set (#2).

Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..

NS_Tests: add test case TC_sns_bss_add_change_del

1. do SNS configuration
2. add a bind
3. receive the SNS_ADD
4. before answering the SNS_ADD, change the weight via vty and remove the bind

Related: OS#5036
Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
---
M ns/NS_Tests.ttcn
1 file changed, 46 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/80/24580/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset


Change in osmo-ttcn3-hacks[master]: NS_Tests: add test case TC_sns_bss_add_change_del

2021-06-06 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580 )


Change subject: NS_Tests: add test case TC_sns_bss_add_change_del
..

NS_Tests: add test case TC_sns_bss_add_change_del

1. do SNS configuration
2. add a bind
3. receive the SNS_ADD
4. before answering the SNS_ADD, change the weight via vty and remove the bind

Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
---
M ns/NS_Tests.ttcn
1 file changed, 46 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/80/24580/1

diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 3971f0d..6d53bd8 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -580,6 +580,51 @@
f_clean_ns_codec();
 }

+/* 1. do SNS configuration
+ * 2. add a bind
+ * 3. receive the SNS_ADD
+ * 4. before answering the SNS_ADD, change the weight via vty and remove the 
bind
+ */
+testcase TC_sns_bss_add_change_del() runs on RAW_Test_CT {
+   var PDU_NS rx;
+   var NSVCConfiguration nsvc_cfg;
+
+   g_handle_rx_alive := true;
+   f_init_vty();
+   f_init_ns_codec(mp_nsconfig);
+   f_init_ns_codec(mp_nsconfig, 1);
+   f_incoming_sns_size();
+   f_incoming_sns_config();
+   f_outgoing_sns_config();
+   activate(as_rx_alive_tx_ack());
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, 
"ip-sns-bind local2");
+
+
+   nsvc_cfg := g_nsconfig.nsvc[1];
+   if (nsvc_cfg.provider.ip.address_family == AF_INET) {
+   var template (omit) IP4_Elements v4_elem := { 
ts_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+1, 1) };
+   rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, v4 := v4_elem), 
0);
+   } else {
+   var template (omit) IP6_Elements v6_elem := { 
ts_SNS_IPv6(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+1, 1) };
+   rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, omit, v6_elem), 
0);
+   }
+
+   /* delete the endpoint */
+   f_vty_config2(NSVTY, {"ns", "bind udp local2"}, "ip-sns 
signalling-weight 99 data-weight 99");
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, "no 
ip-sns-bind local2");
+   NSCP[0].send(ts_SNS_ACK(g_nsconfig.nsei, rx.pDU_SNS_Add.transactionID));
+
+   //f_ns_exp(tr_SNS_CHG_WEIGHT(g_nsconfig.nsei, ?, ?, ?), 0)
+   f_incoming_sns_chg_weight(idx_chg := 1);
+   f_incoming_sns_del(idx_del := 1, w_sig := 99, w_user := 99);
+   setverdict(pass);
+   f_clean_ns_codec();
+}
+
 control {
if (mp_dialect == NS2_DIALECT_STATIC_RESETBLOCK or mp_dialect == 
NS2_DIALECT_IPACCESS) {
execute( TC_tx_reset() );
@@ -629,6 +674,7 @@
execute( TC_sns_bss_change_weight_timeout() );
execute( TC_sns_bss_add() );
execute( TC_sns_bss_del() );
+   execute( TC_sns_bss_add_change_del() );
}
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc565bba4c7e0a0b4dd28a48847dbdb998c8528d
Gerrit-Change-Number: 24580
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange