Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 )
Change subject: PCU_Tests: verify handling of frequency hopping parameters
..
PCU_Tests: verify handling of frequency hopping parameters
Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5
Related: SYS#4868, OS#4547
---
M pcu/PCU_Tests.ttcn
1 file changed, 271 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index dab87e0..1c77256 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -2069,6 +2069,266 @@
f_shutdown(__BFILE__, __LINE__, final := true);
}
+private function f_TC_pcuif_fh_check_imm_ass(in PCUIF_info_ind info_ind,
+in GsmRrMessage rr_msg)
+{
+ var ImmediateAssignment ia := rr_msg.payload.imm_ass;
+ var PCUIF_InfoTrxTs ts := info_ind.trx.v10[0].ts[ia.pkt_chan_desc.tn];
+
+ var template PacketChannelDescription tr_pkt_chan_desc := {
+ channel_Type_spare := ?,
+ tn := ?,
+ tsc := ts.tsc,
+ presence := '1'B,
+ zero := omit,
+ one := {
+ maio := ts.maio,
+ hsn := ts.hsn
+ }
+ };
+
+ if (not match(ia.pkt_chan_desc, tr_pkt_chan_desc)) {
+ setverdict(fail, "Packet Channel Description does not match: ",
+ ia.pkt_chan_desc, " vs ", tr_pkt_chan_desc);
+ }
+
+ var MobileAllocation tr_ma := { len := 0, ma := ''B };
+ var octetstring ma_oct := bit2oct(ts.ma);
+
+ /* Calculate length of the useful part of Mobile Allocation */
+ for (var integer i := 0; i < lengthof(ma_oct); i := i + 1) {
+ if (ma_oct[i] != '00'O) {
+ tr_ma.len := i + 1;
+ }
+ }
+
+ /* Strip zero bytes from the right side of MA */
+ tr_ma.ma := substr(ts.ma, 0, tr_ma.len * 8);
+
+ if (not match(ia.mobile_allocation, tr_ma)) {
+ setverdict(fail, "Mobile Allocation does not match: ",
+ ia.mobile_allocation, " vs ", tr_ma);
+ }
+
+ setverdict(pass);
+}
+
+/* Make sure that Immediate (UL EGPRS TBF) Assignment contains hopping
parameters */
+testcase TC_pcuif_fh_imm_ass_ul_egprs() runs on RAW_PCU_Test_CT {
+ var template PCUIF_info_ind info_ind := ts_PCUIF_INFO_default;
+ var GprsMS ms := valueof(t_GprsMS_def);
+
+ /* Enable frequency hopping of TRX0/TS7 */
+ info_ind.trx.v10[0].ts[7] := ts_PCUIF_InfoTrxTsH1(
+ tsc := f_rnd_int(7),
+ hsn := f_rnd_int(63),
+ maio := f_rnd_int(63),
+ ma := f_rnd_bitstring(32));
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename(), info_ind);
+
+ /* EGPRS Packet Channel Request (cause=Signalling) */
+ f_ms_use_ra(ms, bit2int('11001101010'B), ra_is_11bit := 1);
+
+ /* Establish an Uplink EGPRS TBF */
+ f_ms_establish_ul_tbf(ms);
+
+ f_TC_pcuif_fh_check_imm_ass(valueof(info_ind), ms.ul_tbf.rr_imm_ass);
+ f_shutdown(__BFILE__, __LINE__, final := true);
+}
+
+/* Make sure that Immediate (UL TBF) Assignment contains hopping parameters */
+testcase TC_pcuif_fh_imm_ass_ul() runs on RAW_PCU_Test_CT {
+ var template PCUIF_info_ind info_ind := ts_PCUIF_INFO_default;
+ var GprsMS ms := valueof(t_GprsMS_def);
+
+ /* Enable frequency hopping of TRX0/TS7 */
+ info_ind.trx.v10[0].ts[7] := ts_PCUIF_InfoTrxTsH1(
+ tsc := f_rnd_int(7),
+ hsn := f_rnd_int(63),
+ maio := f_rnd_int(63),
+ ma := f_rnd_bitstring(32));
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename(), info_ind);
+
+ /* Establish an Uplink TBF */
+ f_ms_establish_ul_tbf(ms);
+
+ f_TC_pcuif_fh_check_imm_ass(valueof(info_ind), ms.ul_tbf.rr_imm_ass);
+ f_shutdown(__BFILE__, __LINE__, final := true);
+}
+
+/* Make sure that Immediate (DL TBF) Assignment contains hopping parameters */
+testcase TC_pcuif_fh_imm_ass_dl() runs on RAW_PCU_Test_CT {
+ var template PCUIF_info_ind info_ind := ts_PCUIF_INFO_default;
+ var GprsMS ms := valueof(t_GprsMS_def);
+
+ /* Enable frequency hopping of TRX0/TS7 */
+ info_ind.trx.v10[0].ts[7] := ts_PCUIF_InfoTrxTsH1(
+ tsc := f_rnd_int(7),
+ hsn := f_rnd_int(63),
+ maio := f_rnd_int(63),
+ ma := f_rnd_bitstring(16));
+
+ /* Initialize NS/BSSGP side */
+ f_init_bssgp();
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename(), info_ind);
+
+ /* Establish BSSGP connection to
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 to look at the new patch set (#11). Change subject: PCU_Tests: verify handling of frequency hopping parameters .. PCU_Tests: verify handling of frequency hopping parameters Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Related: SYS#4868, OS#4547 --- M pcu/PCU_Tests.ttcn 1 file changed, 271 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/19324/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Jul 2020 08:26:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Jul 2020 08:15:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 to look at the new patch set (#5). Change subject: PCU_Tests: verify handling of frequency hopping parameters .. PCU_Tests: verify handling of frequency hopping parameters Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Related: SYS#4868, OS#4547 --- M pcu/PCU_Tests.ttcn 1 file changed, 271 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/19324/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 21 Jul 2020 09:23:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Jul 2020 21:28:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 to look at the new patch set (#4). Change subject: PCU_Tests: verify handling of frequency hopping parameters .. PCU_Tests: verify handling of frequency hopping parameters Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Related: SYS#4868, OS#4547 --- M pcu/PCU_Tests.ttcn 1 file changed, 128 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/19324/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 20 Jul 2020 14:13:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324/2/pcu/PCU_Tests.ttcn@2077 PS2, Line 2077: 0, maio := 0 > I would probably test with non-zero values given that we initialize > everything to zero... […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 20 Jul 2020 13:36:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 ) Change subject: PCU_Tests: verify handling of frequency hopping parameters .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5 Gerrit-Change-Number: 19324 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 20 Jul 2020 13:31:21 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify handling of frequency hopping parameters
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324 )
Change subject: PCU_Tests: verify handling of frequency hopping parameters
..
PCU_Tests: verify handling of frequency hopping parameters
Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5
Related: SYS#4868, OS#4547
---
M pcu/PCU_Tests.ttcn
1 file changed, 52 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/24/19324/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 9fc5ab6..794780c 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -2069,6 +2069,52 @@
f_shutdown(__BFILE__, __LINE__, final := true);
}
+/* Make sure that Immediate (UL TBF) Assignment contains hopping parameters */
+testcase TC_pcuif_fh_imm_ass_ul() runs on RAW_PCU_Test_CT {
+ var template PCUIF_info_ind info_ind := ts_PCUIF_INFO_default;
+ var uint8_t ra8 := bit2int(chan_req_def);
+
+ info_ind.trx.v10[0].ts[7] := ts_PCUIF_InfoTrxTsH1(hsn := 0, maio := 0);
+ info_ind.trx.v10[0].ts[7].ma := oct2bit(f_pad_oct('F0'O, 8, '00'O));
+
+ /* Initialize the PCU interface abstraction */
+ f_init_raw(testcasename(), info_ind);
+
+ BTS.send(ts_PCUIF_RACH_IND(bts_nr := 0, trx_nr := 0, ts_nr := 0,
+ ra := ra8, is_11bit := 0,
+ burst_type := BURST_TYPE_0,
+ fn := 1337, arfcn := 871));
+
+ var template PacketChannelDescription ch_desc := {
+ channel_Type_spare := ?,
+ tn := 7, tsc := 7,
+ presence := '1'B,
+ zero := omit,
+ one := {
+ maio := 0,
+ hsn := 0
+ }
+ };
+
+ var template MobileAllocation ma := {
+ len := 1,
+ ma := ''B
+ };
+
+ var GsmRrMessage rr_msg := f_pcuif_rx_imm_ass();
+ if (not match(rr_msg, tr_IMM_TBF_ASS(dl := false, ra := ra8, fn := 1337,
+ch_desc := ch_desc, ma := ma))) {
+ setverdict(fail, "Immediate Assignment does not match");
+ }
+
+ f_shutdown(__BFILE__, __LINE__, final := true);
+}
+
+/* Make sure that Immediate (DL TBF) Assignment contains hopping parameters */
+testcase TC_pcuif_fh_imm_ass_dl() runs on RAW_PCU_Test_CT {
+ /* TODO */
+}
+
control {
execute( TC_pcuif_suspend() );
execute( TC_ta_ptcch_idle() );
@@ -2109,6 +2155,12 @@
execute( TC_egprs_pkt_chan_req_reject_exhaustion() );
execute( TC_mo_ping_pong_with_ul_racap_egprs_only() );
+
+ /* Frequency hopping specific test cases */
+ if (PCUIF_Types.mp_pcuif_version >= 10) {
+ execute( TC_pcuif_fh_imm_ass_ul() );
+ execute( TC_pcuif_fh_imm_ass_dl() );
+ }
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19324
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1beda9224998848f9243237413e5ae3e0ddab8a5
Gerrit-Change-Number: 19324
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
