Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...

2021-06-07 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 )

Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the 
chg_weight over a different
..

RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_weight over a 
different

The SGSN/PCU will use a different NSVC as the NSVC which will be changed 
weight'ed.

Related: OS#5036
Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
---
M library/RAW_NS.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp
index 8f986e4..42efb7d 100644
--- a/library/RAW_NS.ttcnpp
+++ b/library/RAW_NS.ttcnpp
@@ -408,11 +408,11 @@
 }

 /* perform inbound SNS-CHANGE-WEIGHT procedure */
-function f_incoming_sns_chg_weight(template (omit) NsCause cause := omit, 
integer idx := 0)
+function f_incoming_sns_chg_weight(integer idx_chg := 0, template (omit) 
NsCause cause := omit, integer idx := 0)
 runs on RAW_NS_CT {
log("f_incoming_sns_chg_weight(idx=", idx, ")");
var PDU_NS rx;
-   var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx];
+   var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx_chg];

if (nsvc_cfg.provider.ip.address_family == AF_INET) {
var template IP4_Elements v4_elem := { 
tr_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...

2021-06-07 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 )

Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the 
chg_weight over a different
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 12:49:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...

2021-06-07 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 )

Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the 
chg_weight over a different
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 09:22:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...

2021-06-06 Thread lynxis lazus 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578

to look at the new patch set (#2).

Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the 
chg_weight over a different
..

RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_weight over a 
different

The SGSN/PCU will use a different NSVC as the NSVC which will be changed 
weight'ed.

Related: OS#5036
Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
---
M library/RAW_NS.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/78/24578/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_wei...

2021-06-06 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578 )


Change subject: RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the 
chg_weight over a different
..

RAW_NS: f_incoming_sns_chg_weight() allow to receive/send the chg_weight over a 
different

The SGSN/PCU will use a different NSVC as the NSVC which will be changed 
weight'ed.

Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
---
M library/RAW_NS.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/78/24578/1

diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp
index 8f986e4..42efb7d 100644
--- a/library/RAW_NS.ttcnpp
+++ b/library/RAW_NS.ttcnpp
@@ -408,11 +408,11 @@
 }

 /* perform inbound SNS-CHANGE-WEIGHT procedure */
-function f_incoming_sns_chg_weight(template (omit) NsCause cause := omit, 
integer idx := 0)
+function f_incoming_sns_chg_weight(integer idx_chg := 0, template (omit) 
NsCause cause := omit, integer idx := 0)
 runs on RAW_NS_CT {
log("f_incoming_sns_chg_weight(idx=", idx, ")");
var PDU_NS rx;
-   var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx];
+   var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx_chg];

if (nsvc_cfg.provider.ip.address_family == AF_INET) {
var template IP4_Elements v4_elem := { 
tr_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24578
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5766afaa74db30d94318312ab775e7933b9df783
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange