Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

2018-10-23 Thread daniel 
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG@9
PS2, Line 9: Otherwise RSL layer fails this way when this event is received:
> Why are we expecting the RSL layer to ever receive an ASP_IPA_EVENT_DOWN?  I 
> agree the message is a  […]
I spoke with pespin and we basically concluded, that this seems to be another 
issue due to high load. The BTS
did not receive the clock from osmo-trx (or what's driving osmo-bts in the 
test).

‎[19:21:15] ‎pespin‎: Wed Oct 17 07:22:32 2018 DOML <0001> bts.c:239 Shutting 
down BTS 0, Reason No clock from osmo-trx

So failing explicitly in these cases seems the better idea.

For an explicit failure you should call "all component.stop" after the 
setverdict(fail) so that we don't run into any dynamic testcase errors due to 
unconnected ports that get messages.
‎
BTS_Tests has an f_shutdown function which does that exactly and should 
probably be moved to a common place since this should just be callable from 
about anywhere.



--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 23 Oct 2018 17:29:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

2018-10-22 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG@9
PS2, Line 9: Otherwise RSL layer fails this way when this event is received:
Why are we expecting the RSL layer to ever receive an ASP_IPA_EVENT_DOWN?  I 
agree the message is a bit cryptic, but I'm not sure if it is the right 
approach to simply ignore it.  Rather than ignoring, we could explicitly 
fail/stop?



--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:21:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

2018-10-22 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11429


Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
..

RSL_Emulation: handle ASP_IPA_EVENT_DOWN

Otherwise RSL layer fails this way when this event is received:

RSL_Emulation.ttcn:429 Receive operation on port IPA_PT succeeded, message from 
TC_chan_act_a51-RSL-IPA(3): @IPA_Emulation.ASP_IPA_Event: { up_down := 
ASP_IPA_EVENT_DOWN (0) } id 9
- Function main_client was stopped. PTC terminates.
RSL_Emulation.ttcn:429 Message with id 9 was extracted from the queue of IPA_PT.
RSL_Emulation.ttcn:430 setverdict(fail): none -> fail reason: "Received unknown 
primitive from IPA", new component reason: "Received unknown primitive from IPA"

Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
---
M library/RSL_Emulation.ttcn
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/29/11429/1

diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index c56c278..57efcc1 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -346,6 +346,11 @@
[not bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_UP}) -> value evt {
CCHAN_PT.send(evt);
}
+   [bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_DOWN}) {
+   }
+   [not bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_DOWN}) -> value evt {
+   CCHAN_PT.send(evt);
+   }
[bts_role] IPA_PT.receive(ASP_IPA_Event:{up_down := 
ASP_IPA_EVENT_ID_ACK}) {

IPA_PT.send(ts_ASP_RSL_UD(IPAC_PROTO_RSL_TRX0,ts_RSL_PAGING_LOAD_IND(23)));
}

--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol