Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

2020-08-06 Thread laforge 
laforge has abandoned this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )

Change subject: bsc CBSP: log expected response in f_cbsp_write
..


Abandoned

loggign was only required during R, not now anymore
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: abandon

Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

2020-08-04 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )

Change subject: bsc CBSP: log expected response in f_cbsp_write
..


Patch Set 1: Code-Review-1

ok, then let's not merge it.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 04 Aug 2020 09:17:59 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

2020-07-30 Thread neels 
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )

Change subject: bsc CBSP: log expected response in f_cbsp_write
..


Patch Set 1:

> Patch Set 1:
>
> doesnt the MATCH log category print that kind of information? I would 
> generally prefer us not to add hand-written log statements if the same can be 
> achieved by changing the TITAN logger configuriation for this component to 
> include matching information.

For me it is super handy to have one specific string to search for in the log 
output that directly shows me what message is expected at that precise line in 
the test.
I am aware that the matching and mismatching is shown in the logging, but with 
that alone I find it hard to find the expected message I am looking for...
The purpose of this log message is basically served when the problem is fixed, 
so I'm also fine with not merging it.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Jul 2020 14:31:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

2020-07-29 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )

Change subject: bsc CBSP: log expected response in f_cbsp_write
..


Patch Set 1:

doesnt the MATCH log category print that kind of information? I would generally 
prefer us not to add hand-written log statements if the same can be achieved by 
changing the TITAN logger configuriation for this component to include matching 
information.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Jul 2020 20:03:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

2020-07-29 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )

Change subject: bsc CBSP: log expected response in f_cbsp_write
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Jul 2020 11:58:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: bsc CBSP: log expected response in f_cbsp_write

2020-07-28 Thread neels 
neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433 )


Change subject: bsc CBSP: log expected response in f_cbsp_write
..

bsc CBSP: log expected response in f_cbsp_write

This helped to find message mismatches while solving the current CBSP test
failures.

Change-Id: I844717b0f665496a842764b3b915ba64249cd617
---
M bsc/BSC_Tests_CBSP.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/33/19433/1

diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn
index acd0b99..d6a4b82 100644
--- a/bsc/BSC_Tests_CBSP.ttcn
+++ b/bsc/BSC_Tests_CBSP.ttcn
@@ -208,6 +208,7 @@
} else {
rx := tr_CBSP_WRITE_CBS_FAIL(msg_id, ser_no, fail_list, *, 
success_list, channel_ind);
}
+   log("EXPECTING ", tr_CBSP_Recv(g_cbsp_conn_id[0], rx));
alt {
[] CBSP[0].receive(tr_CBSP_Recv(g_cbsp_conn_id[0], rx)) {
setverdict(pass);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I844717b0f665496a842764b3b915ba64249cd617
Gerrit-Change-Number: 19433
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange