Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..

bts: Disable testing FACCH/H with real HW

Temporary disable testing on FACCH/H because Calypso PHY is not stable.
Otherwise some tests fail half of the time due to this unstability.

Related: OS#3653
Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
---
M bts/BTS_Tests.ttcn
1 file changed, 22 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index a2d4ca4..fe0a933 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -313,17 +313,29 @@
valueof(ts_RslChanNr_SDCCH8(6,4)), 
valueof(ts_RslChanNr_SDCCH8(6,5)),
valueof(ts_RslChanNr_SDCCH8(6,6)), 
valueof(ts_RslChanNr_SDCCH8(6,7))
};
-   g_AllChanTypes := {
-   /* TS 1..4: TCH/F */
-   valueof(ts_RslChanNr_Bm(1)),
-   /* TS 5: TCH/H */
-   valueof(ts_RslChanNr_Lm(5,1)),
-   /* TS 0: SDCCH/4 */
-   valueof(ts_RslChanNr_SDCCH4(0,2)),
-   /* TS 6: SDCCH/8 */
-   valueof(ts_RslChanNr_SDCCH8(6,4))
-   };

+   /* FIXME: FACCH/H is unreliable with calypso firmware, see OS#3653 */
+   if (mp_bb_trxc_port != -1) {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 5: TCH/H */
+   valueof(ts_RslChanNr_Lm(5,1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   } else {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   }
f_init_rsl(id);
T.start;
alt {

--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

2018-10-22 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11428/2/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11428/2/bts/BTS_Tests.ttcn@336
PS2, Line 336:  };
rather than copy+pasting the entire array, one could probably have simply used 
the "append" operator (&) to add the one additional element in case 
mp_bb_trxc_port==-1.  But well, not critical.



--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:19:56 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

2018-10-22 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 17:12:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

2018-10-22 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11428/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11428/1//COMMIT_MSG@7
PS1, Line 7: bts: Disable testing FACCH/H with real HW
Would be great to point out that we *temporary* disable
testing on FACCH/H *because* Calypso PHY is not stable.


https://gerrit.osmocom.org/#/c/11428/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11428/1/bts/BTS_Tests.ttcn@316
PS1, Line 316: FACCH/H is unreliable with calypso firmware, see OS#3653
Let's format this comment as "FIXME: ...".



--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 22 Oct 2018 14:43:37 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

2018-10-22 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11428


Change subject: bts: Disable testing FACCH/H with real HW
..

bts: Disable testing FACCH/H with real HW

Related: OS#3653
Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
---
M bts/BTS_Tests.ttcn
1 file changed, 22 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/28/11428/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 2f48b0f..3debb62 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -312,17 +312,29 @@
valueof(ts_RslChanNr_SDCCH8(6,4)), 
valueof(ts_RslChanNr_SDCCH8(6,5)),
valueof(ts_RslChanNr_SDCCH8(6,6)), 
valueof(ts_RslChanNr_SDCCH8(6,7))
};
-   g_AllChanTypes := {
-   /* TS 1..4: TCH/F */
-   valueof(ts_RslChanNr_Bm(1)),
-   /* TS 5: TCH/H */
-   valueof(ts_RslChanNr_Lm(5,1)),
-   /* TS 0: SDCCH/4 */
-   valueof(ts_RslChanNr_SDCCH4(0,2)),
-   /* TS 6: SDCCH/8 */
-   valueof(ts_RslChanNr_SDCCH8(6,4))
-   };

+   /* FACCH/H is unreliable with calypso firmware, see OS#3653 */
+   if (mp_bb_trxc_port != -1) {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 5: TCH/H */
+   valueof(ts_RslChanNr_Lm(5,1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   } else {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   }
f_init_rsl(id);
T.start;
alt {

--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol