Change in osmo-ttcn3-hacks[master]: ggsn: Apply GPDU seqnum option to all APNs

2018-07-06 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9896 )

Change subject: ggsn: Apply GPDU seqnum option to all APNs
..

ggsn: Apply GPDU seqnum option to all APNs

Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 20 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 97abc4d..6ae205f 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -105,12 +105,29 @@
private function f_vty_set_gpdu_txseq(boolean enable) runs on GT_CT {
f_vty_enter_config(GGSNVTY);
f_vty_transceive(GGSNVTY, "ggsn ggsn0");
+
f_vty_transceive(GGSNVTY, "apn internet");
if (enable) {
f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
} else {
f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
}
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet6");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet46");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
f_vty_transceive(GGSNVTY, "end");
}

diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index 383ea39..081325e 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -1,10 +1,11 @@
 
-
+
   
   
   
   
-  
+  
+  
   
   
 Secondary DNS IPv4 PCO option not found

--
To view, visit https://gerrit.osmocom.org/9896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
Gerrit-Change-Number: 9896
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder


Change in osmo-ttcn3-hacks[master]: ggsn: Apply GPDU seqnum option to all APNs

2018-07-06 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9896 )

Change subject: ggsn: Apply GPDU seqnum option to all APNs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
Gerrit-Change-Number: 9896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:43:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-ttcn3-hacks[master]: ggsn: Apply GPDU seqnum option to all APNs

2018-07-06 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9896


Change subject: ggsn: Apply GPDU seqnum option to all APNs
..

ggsn: Apply GPDU seqnum option to all APNs

Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 20 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/96/9896/1

diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 97abc4d..6ae205f 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -105,12 +105,29 @@
private function f_vty_set_gpdu_txseq(boolean enable) runs on GT_CT {
f_vty_enter_config(GGSNVTY);
f_vty_transceive(GGSNVTY, "ggsn ggsn0");
+
f_vty_transceive(GGSNVTY, "apn internet");
if (enable) {
f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
} else {
f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
}
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet6");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet46");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
f_vty_transceive(GGSNVTY, "end");
}

diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index 383ea39..081325e 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -1,10 +1,11 @@
 
-
+
   
   
   
   
-  
+  
+  
   
   
 Secondary DNS IPv4 PCO option not found

--
To view, visit https://gerrit.osmocom.org/9896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
Gerrit-Change-Number: 9896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol