Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on GERAN
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 )
Change subject: msc: expect only one Paging on GERAN
..
msc: expect only one Paging on GERAN
After discussion on this thread:
http://lists.osmocom.org/pipermail/openbsc/2019-November/013058.html
Do not expect repeated Paging on GERAN.
Pending clarification on 3G, still expect repeated Paging on Iu, though we are
not 100% certain that this is indeed required.
Fixes MSC_Tests.TC_lu_and_mt_sms_paging_repeated,
but not MSC_Tests_Iu.TC_iu_lu_and_mt_sms_paging_repeated
Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b
---
M msc/MSC_Tests.ttcn
1 file changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/01/16301/1
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 1a16dbf..c4d407a 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2030,11 +2030,37 @@
f_vty_sms_send(hex2str(pars.imsi), "2342", "Hello SMS");
+ f_logp("Expecting first Paging");
/* MSC->BSC: expect PAGING from MSC */
f_expect_paging();
- /* MSC->BSC: expect PAGING from MSC */
- f_expect_paging();
+ if (g_pars.ran_is_geran) {
+ f_logp("GERAN: expect no further Paging");
+ } else {
+ f_logp("UTRAN: expect more Paging");
+ }
+
+ timer T := 5.0;
+ T.start;
+ alt {
+ [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {
+ setverdict(fail, "GERAN should not repeat Paging, but received
a second Paging");
+ mtc.stop;
+ }
+ [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain,
imsi_hex2oct(g_pars.imsi))) {
+ f_logp("UTRAN: second Paging received, as expected");
+ setverdict(pass);
+ }
+ [] T.timeout {
+ if (g_pars.ran_is_geran) {
+ f_logp("GERAN: No further Paging received, as
expected");
+ setverdict(pass);
+ } else {
+ setverdict(fail, "UTRAN: Expected a second Paging");
+ mtc.stop;
+ }
+ }
+ }
/* Establish DTAP / BSSAP / SCCP connection */
f_establish_fully(EST_TYPE_PAG_RESP);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b
Gerrit-Change-Number: 16301
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on GERAN
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 ) Change subject: msc: expect only one Paging on GERAN .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b Gerrit-Change-Number: 16301 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 02 Dec 2019 23:24:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on GERAN
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 to look at the new patch set (#3). Change subject: msc: expect only one Paging on GERAN .. msc: expect only one Paging on GERAN After discussion on this thread: http://lists.osmocom.org/pipermail/openbsc/2019-November/013058.html Do not expect repeated Paging on GERAN. Pending clarification on 3G, still expect repeated Paging on Iu, though we are not 100% certain that this is indeed required. Fixes MSC_Tests.TC_lu_and_mt_sms_paging_repeated, but not MSC_Tests_Iu.TC_iu_lu_and_mt_sms_paging_repeated Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b --- M msc/MSC_Tests.ttcn 1 file changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/16301/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b Gerrit-Change-Number: 16301 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on GERAN
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 )
Change subject: msc: expect only one Paging on GERAN
..
msc: expect only one Paging on GERAN
After discussion on this thread:
http://lists.osmocom.org/pipermail/openbsc/2019-November/013058.html
Do not expect repeated Paging on GERAN.
Pending clarification on 3G, still expect repeated Paging on Iu, though we are
not 100% certain that this is indeed required.
Fixes MSC_Tests.TC_lu_and_mt_sms_paging_repeated,
but not MSC_Tests_Iu.TC_iu_lu_and_mt_sms_paging_repeated
Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b
---
M msc/MSC_Tests.ttcn
1 file changed, 28 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
neels: Looks good to me, approved
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 6e482e2..a083606 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1974,11 +1974,37 @@
f_vty_sms_send(hex2str(pars.imsi), "2342", "Hello SMS");
+ log("Expecting first Paging");
/* MSC->BSC: expect PAGING from MSC */
f_expect_paging();
- /* MSC->BSC: expect PAGING from MSC */
- f_expect_paging();
+ if (g_pars.ran_is_geran) {
+ log("GERAN: expect no further Paging");
+ } else {
+ log("UTRAN: expect more Paging");
+ }
+
+ timer T := 5.0;
+ T.start;
+ alt {
+ [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {
+ setverdict(fail, "GERAN should not repeat Paging, but received
a second Paging");
+ mtc.stop;
+ }
+ [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain,
imsi_hex2oct(g_pars.imsi))) {
+ log("UTRAN: second Paging received, as expected");
+ setverdict(pass);
+ }
+ [] T.timeout {
+ if (g_pars.ran_is_geran) {
+ log("GERAN: No further Paging received, as expected");
+ setverdict(pass);
+ } else {
+ setverdict(fail, "UTRAN: Expected a second Paging");
+ mtc.stop;
+ }
+ }
+ }
/* Establish DTAP / BSSAP / SCCP connection */
f_establish_fully(EST_TYPE_PAG_RESP);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b
Gerrit-Change-Number: 16301
Gerrit-PatchSet: 3
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on GERAN
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 ) Change subject: msc: expect only one Paging on GERAN .. Patch Set 3: Code-Review+2 Re-adding previous +2, which was only lost from removing the orthogonal f_logp() feature (put in a separate patch now) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b Gerrit-Change-Number: 16301 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 12 Dec 2019 15:33:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
