Change in osmocom-bb[master]: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the...
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/19482 )
Change subject: firmware/abb: Wrote twl3025_power_off_now to restart the phone
if the power button is pressed
..
firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power
button is pressed
I am not sure how other developers do this. There are probably better ways to
make testing faster but I kind of like it this way.
I just call the twl3025_power_off_now function when the power key is pressed.
Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3
---
M src/target/firmware/abb/twl3025.c
M src/target/firmware/include/abb/twl3025.h
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/target/firmware/abb/twl3025.c
b/src/target/firmware/abb/twl3025.c
index ad2b01f..5b792d6 100644
--- a/src/target/firmware/abb/twl3025.c
+++ b/src/target/firmware/abb/twl3025.c
@@ -229,6 +229,15 @@
twl3025_reg_write(VRPCDEV, 0x01);
}
+void twl3025_power_off_now(void)
+{
+ /* The phone will restart if the power butten has not been released.
+* This can be useful for development. */
+ unsigned long flags;
+ local_firq_save(flags);
+ twl3025_reg_write(VRPCDEV, 0x01);
+}
+
void twl3025_clk13m(int enable)
{
if (enable) {
diff --git a/src/target/firmware/include/abb/twl3025.h
b/src/target/firmware/include/abb/twl3025.h
index 727bde0..8bc2fb9 100755
--- a/src/target/firmware/include/abb/twl3025.h
+++ b/src/target/firmware/include/abb/twl3025.h
@@ -147,6 +147,7 @@
int twl3025_get_pwon(void);
void twl3025_power_off(void);
+void twl3025_power_off_now(void);
void twl3025_clk13m(int enable);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3
Gerrit-Change-Number: 19482
Gerrit-PatchSet: 2
Gerrit-Owner: roox
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-CC: fixeria
Gerrit-MessageType: merged
Change in osmocom-bb[master]: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19482 ) Change subject: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 Gerrit-Change-Number: 19482 Gerrit-PatchSet: 2 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 06 Aug 2020 16:37:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/19482 ) Change subject: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 Gerrit-Change-Number: 19482 Gerrit-PatchSet: 2 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 02 Aug 2020 17:23:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the...
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482 to look at the new patch set (#2). Change subject: firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed .. firmware/abb: Wrote twl3025_power_off_now to restart the phone if the power button is pressed I am not sure how other developers do this. There are probably better ways to make testing faster but I kind of like it this way. I just call the twl3025_power_off_now function when the power key is pressed. Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 --- M src/target/firmware/abb/twl3025.c M src/target/firmware/include/abb/twl3025.h 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/82/19482/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/19482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e55910acd8584c74e5e190b3334a8cf6987f5f3 Gerrit-Change-Number: 19482 Gerrit-PatchSet: 2 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
