Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 7: Code-Review+2 No regressions observed during testing, LGTM! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 07 Oct 2020 20:26:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Thu, 01 Oct 2020 00:02:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
laforge has uploaded a new patch set (#7) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. firmware: implement reading of factory RF calibration values Since If6e212baeb10953129fb0d5253d263567f5e12d6, we can read the TIFFS file-system, thus we can read and use the factory RF calibration values. * Implement parsing of factory RF calibration values for Motorola C1xx, Openmoko GTA0x, Pirelli DP-L10, and upcoming FCDEV3B targets. * Remove the old Tx power level control code and tables, and replace them with new logic that exactly matches what the official chipset firmware (TI/FreeCalypso) does, using tables in TI/FreeCalypso format. Compiled-in tables serve as a fallback and match each target's respective original firmware. * Use individual AFC slope values for different targets. The original value was/is only correct for the Mot C1xx family, whereas GTA0x/FCDEV3B and Pirelli DP-L10 need different values because Openmoko's VCXO (copied on the FCDEV3B) and Pirelli's VCTCXO are different from what Motorola used. * Take the initial AFC DAC value for the FB search from factory calibration records on those targets on which it has been calibrated per unit at the factory. * Use individual APC offset for different targets instead of the hard-coded value. The Mot/Compal's and Pirelli's firmwares (both heavily modified relative to TI) use different APC offset settings: 32 for Compal and 0 for Pirelli, while Openmoko and FreeCalypso devices use 48. Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Related: OS#3582 --- M src/target/firmware/Makefile M src/target/firmware/apps/layer1/main.c M src/target/firmware/apps/rssi/main.c A src/target/firmware/board/common/readcal_tiffs.c A src/target/firmware/board/common/tx_calchan.c A src/target/firmware/board/compal/readcal_common.c A src/target/firmware/board/compal/readcal_small.c D src/target/firmware/board/compal/rf_power.c A src/target/firmware/board/compal/rf_tables.c A src/target/firmware/board/compal_e86/tx_ramps.c A src/target/firmware/board/compal_e88/tx_ramps.c A src/target/firmware/board/compal_e99/readcal.c D src/target/firmware/board/gta0x/rf_power.c A src/target/firmware/board/gta0x/rf_tables.c M src/target/firmware/board/gta0x/rffe_gta0x_triband.c D src/target/firmware/board/gtm900b/rf_power.c A src/target/firmware/board/gtm900b/rf_tables.c A src/target/firmware/board/pirelli_dpl10/readcal.c D src/target/firmware/board/pirelli_dpl10/rf_power.c A src/target/firmware/board/pirelli_dpl10/rf_tables.c A src/target/firmware/board/se_j100/tx_ramps.c D src/target/firmware/include/layer1/apc.h A src/target/firmware/include/rf/readcal.h A src/target/firmware/include/rf/txcal.h A src/target/firmware/include/rf/vcxocal.h M src/target/firmware/layer1/Makefile M src/target/firmware/layer1/afc.c D src/target/firmware/layer1/apc.c M src/target/firmware/layer1/sync.c 29 files changed, 4,023 insertions(+), 351 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/87/12887/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Removed Code-Review-1 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: deleteVote
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 6: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 30 Sep 2020 23:47:37 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 6: Code-Review-1 my bad, the commit now lists myself as author. need to fix that up. Sorry. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 30 Sep 2020 23:47:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Removed Code-Review+2 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: deleteVote
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 5: > @fixeria, what does it take to get this merged? I just need to revisit OS#3582, and apply the recent changes from Mychaela. Let's keep WIP for now. -- To view, visit https://gerrit.osmocom.org/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 10 May 2019 11:41:54 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Patch Set 5: @fixeria, what does it take to get this merged? -- To view, visit https://gerrit.osmocom.org/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 10 May 2019 10:28:11 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmocom-bb[master]: firmware: implement reading of factory RF calibration values
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12887 ) Change subject: firmware: implement reading of factory RF calibration values .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/12887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf2693b751d86ec1d2563412d606c13d4c91a806 Gerrit-Change-Number: 12887 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 10 May 2019 10:27:58 + Gerrit-HasComments: No Gerrit-HasLabels: No
