Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/24659 )
Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
..
trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809
Related: SYS#5313, OS#1569
---
M src/target/trx_toolkit/transceiver.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/target/trx_toolkit/transceiver.py
b/src/target/trx_toolkit/transceiver.py
index d041070..b48dffb 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -269,7 +269,8 @@
return None
# Make sure that indicated timeslot is configured
- if msg.tn not in self.ts_list:
+ # Pass PDUs without burst bits, they will be sent as NOPE.ind
+ if msg.tn not in self.ts_list and msg.burst:
log.warning("(%s) RX TRXD message (%s), but timeslot is
not "
"configured => dropping..." % (self,
msg.desc_hdr()))
return None
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809
Gerrit-Change-Number: 24659
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24659 ) Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Gerrit-Change-Number: 24659 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 16 Jun 2021 13:57:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24659 ) Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Gerrit-Change-Number: 24659 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 16 Jun 2021 13:53:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 to look at the new patch set (#2). Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots .. trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Related: SYS#5313, OS#1569 --- M src/target/trx_toolkit/transceiver.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/24659/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Gerrit-Change-Number: 24659 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24659 ) Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/24659/1/src/target/trx_toolkit/transceiver.py File src/target/trx_toolkit/transceiver.py: https://gerrit.osmocom.org/c/osmocom-bb/+/24659/1/src/target/trx_toolkit/transceiver.py@275 PS1, Line 275: return None > shouldn't you convert this to a NOPE. […] In this function we do not transform from Tx to Rx, we just receive and parse PDUs. NOPE.ind flag will be set during the actual transformation in TxMsg.trans(). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Gerrit-Change-Number: 24659 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 16 Jun 2021 12:44:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24659 ) Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Gerrit-Change-Number: 24659 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 15 Jun 2021 16:43:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24659 ) Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/24659/1/src/target/trx_toolkit/transceiver.py File src/target/trx_toolkit/transceiver.py: https://gerrit.osmocom.org/c/osmocom-bb/+/24659/1/src/target/trx_toolkit/transceiver.py@275 PS1, Line 275: return None shouldn't you convert this to a NOPE.ind? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809 Gerrit-Change-Number: 24659 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 15 Jun 2021 09:34:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmocom-bb[master]: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/24659 )
Change subject: trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
..
trx_toolkit/transceiver.py: allow NOPE.ind on inactive timeslots
Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809
Related: SYS#5313, OS#1569
---
M src/target/trx_toolkit/transceiver.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/24659/1
diff --git a/src/target/trx_toolkit/transceiver.py
b/src/target/trx_toolkit/transceiver.py
index d041070..f6b0551 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -269,7 +269,7 @@
return None
# Make sure that indicated timeslot is configured
- if msg.tn not in self.ts_list:
+ if msg.tn not in self.ts_list and msg.burst:
log.warning("(%s) RX TRXD message (%s), but timeslot is
not "
"configured => dropping..." % (self,
msg.desc_hdr()))
return None
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24659
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I27a3c8897cb82f6c264d34702c4ec64561bb9809
Gerrit-Change-Number: 24659
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
