Change in osmocom-bb[master]: trxcon/trx_if: send NOPE indications if there is no burst
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/24662 )
Change subject: trxcon/trx_if: send NOPE indications if there is no burst
..
trxcon/trx_if: send NOPE indications if there is no burst
In a typical setup operating on the real radio interface, it's
the duty of the transceiver (e.g. osmo-trx) to send NOPE.ind to
the L1 implementation (e.g. osmo-bts-trx). However, in a
virtual environment for ttcn3-bts-test we use a fake transceiver,
which due to its simplicity cannot send NOPE indications itself.
The lack of queues and buffering does not allow us to implement
NOPE indications in fake_trx.py, so the easiest approach is to
generate them from trxcon. Send TRXD PDUs without the burst bits,
and fake_trx.py will tranform them info NOPE.ind for us.
Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946
Related: SYS#5313, OS#1569
---
M src/host/trxcon/trx_if.c
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index c4561ce..8dbbd12 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -635,9 +635,6 @@
uint8_t buf[TRXD_BUF_SIZE];
size_t length;
- if (br->burst_len == 0)
- return 0;
-
/**
* We must be sure that we have clock,
* and we have sent all control data
@@ -662,8 +659,10 @@
length = 6;
/* Copy ubits {0,1} */
- memcpy(buf + 6, br->burst, br->burst_len);
- length += br->burst_len;
+ if (br->burst_len != 0) {
+ memcpy(buf + 6, br->burst, br->burst_len);
+ length += br->burst_len;
+ }
/* Send data to transceiver */
send(trx->trx_ofd_data.fd, buf, length, 0);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946
Gerrit-Change-Number: 24662
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmocom-bb[master]: trxcon/trx_if: send NOPE indications if there is no burst
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24662 ) Change subject: trxcon/trx_if: send NOPE indications if there is no burst .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946 Gerrit-Change-Number: 24662 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 16 Jun 2021 13:57:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/trx_if: send NOPE indications if there is no burst
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662 to look at the new patch set (#4). Change subject: trxcon/trx_if: send NOPE indications if there is no burst .. trxcon/trx_if: send NOPE indications if there is no burst In a typical setup operating on the real radio interface, it's the duty of the transceiver (e.g. osmo-trx) to send NOPE.ind to the L1 implementation (e.g. osmo-bts-trx). However, in a virtual environment for ttcn3-bts-test we use a fake transceiver, which due to its simplicity cannot send NOPE indications itself. The lack of queues and buffering does not allow us to implement NOPE indications in fake_trx.py, so the easiest approach is to generate them from trxcon. Send TRXD PDUs without the burst bits, and fake_trx.py will tranform them info NOPE.ind for us. Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946 Related: SYS#5313, OS#1569 --- M src/host/trxcon/trx_if.c 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/62/24662/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946 Gerrit-Change-Number: 24662 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmocom-bb[master]: trxcon/trx_if: send NOPE indications if there is no burst
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24662 ) Change subject: trxcon/trx_if: send NOPE indications if there is no burst .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946 Gerrit-Change-Number: 24662 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Jun 2021 16:44:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/trx_if: send NOPE indications if there is no burst
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/24662 ) Change subject: trxcon/trx_if: send NOPE indications if there is no burst .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946 Gerrit-Change-Number: 24662 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Jun 2021 09:36:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: trxcon/trx_if: send NOPE indications if there is no burst
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/24662 )
Change subject: trxcon/trx_if: send NOPE indications if there is no burst
..
trxcon/trx_if: send NOPE indications if there is no burst
In a typical setup operating on the real radio interface, it's
the duty of the transceiver (e.g. osmo-trx) to send NOPE.ind to
the L1 implementation (e.g. osmo-bts-trx). However, in a
virtual environment for ttcn3-bts-test we use a fake transceiver,
which due to its simplicity cannot send NOPE indications itself.
The lack of queues and buffering does not allow us to implement
NOPE indications in fake_trx.py, so the easiest approach is to
generate them from trxcon. Send TRXD PDUs without the burst bits,
and fake_trx.py will tranform them info NOPE.ind for us.
Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946
Related: SYS#5313, OS#1569
---
M src/host/trxcon/trx_if.c
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/62/24662/1
diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index c4561ce..8dbbd12 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -635,9 +635,6 @@
uint8_t buf[TRXD_BUF_SIZE];
size_t length;
- if (br->burst_len == 0)
- return 0;
-
/**
* We must be sure that we have clock,
* and we have sent all control data
@@ -662,8 +659,10 @@
length = 6;
/* Copy ubits {0,1} */
- memcpy(buf + 6, br->burst, br->burst_len);
- length += br->burst_len;
+ if (br->burst_len != 0) {
+ memcpy(buf + 6, br->burst, br->burst_len);
+ length += br->burst_len;
+ }
/* Send data to transceiver */
send(trx->trx_ofd_data.fd, buf, length, 0);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/24662
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1c7f1315b8ef44f651efd6a22fb5b854f65c0946
Gerrit-Change-Number: 24662
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
