Change in osmocom-bb[master]: trxcon: log FBSB timer events
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13364 ) Change subject: trxcon: log FBSB timer events .. trxcon: log FBSB timer events Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 --- M src/host/trxcon/l1ctl.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index b37082e..8145936 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -295,7 +295,7 @@ if (msg == NULL) return; - LOGP(DL1C, LOGL_DEBUG, "Send FBSB Conf (result=255, bsic=0)\n"); + LOGP(DL1C, LOGL_NOTICE, "FBSB timer fired for ARFCN %u\n", l1l->trx->band_arfcn &~ ARFCN_FLAG_MASK); dl = put_dl_info_hdr(msg, NULL); @@ -361,6 +361,7 @@ /* Start FBSB expire timer */ l1l->fbsb_timer.data = l1l; l1l->fbsb_timer.cb = fbsb_timer_cb; + LOGP(DL1C, LOGL_INFO, "Starting FBSB timer %u ms\n", timeout * FRAME_DURATION_uS / 1000); osmo_timer_schedule(&l1l->fbsb_timer, 0, timeout * FRAME_DURATION_uS); -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith
Change in osmocom-bb[master]: trxcon: log FBSB timer events
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13364 ) Change subject: trxcon: log FBSB timer events .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 22 Mar 2019 09:30:52 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: trxcon: log FBSB timer events
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13364 ) Change subject: trxcon: log FBSB timer events .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 17:36:16 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: trxcon: log FBSB timer events
Hello Vadim Yanitskiy, Harald Welte, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13364 to look at the new patch set (#2). Change subject: trxcon: log FBSB timer events .. trxcon: log FBSB timer events Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 --- M src/host/trxcon/l1ctl.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/13364/2 -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith
Change in osmocom-bb[master]: trxcon: log FBSB timer events
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13364 ) Change subject: trxcon: log FBSB timer events .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Max Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 21 Mar 2019 15:48:33 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmocom-bb[master]: trxcon: log FBSB timer events
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13364 Change subject: trxcon: log FBSB timer events .. trxcon: log FBSB timer events Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 --- M src/host/trxcon/l1ctl.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/13364/1 diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index b37082e..6c72b9e 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -295,7 +295,7 @@ if (msg == NULL) return; - LOGP(DL1C, LOGL_DEBUG, "Send FBSB Conf (result=255, bsic=0)\n"); + LOGP(DL1C, LOGL_NOTICE, "FBSB timer fired for ARFCN %u\n", l1l->trx->band_arfcn &~ ARFCN_FLAG_MASK); dl = put_dl_info_hdr(msg, NULL); @@ -361,6 +361,7 @@ /* Start FBSB expire timer */ l1l->fbsb_timer.data = l1l; l1l->fbsb_timer.cb = fbsb_timer_cb; + LOGP(DL1C, LOGL_INFO, "Starting FBSB timer %uus\n", timeout * FRAME_DURATION_uS); osmo_timer_schedule(&l1l->fbsb_timer, 0, timeout * FRAME_DURATION_uS); -- To view, visit https://gerrit.osmocom.org/13364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0168d43951494f4010df891f391ddad4b57493d7 Gerrit-Change-Number: 13364 Gerrit-PatchSet: 1 Gerrit-Owner: Max
