Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-05 Thread Robert Falkenberg
Robert Falkenberg has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/23632 )

Change subject: Set uSIM to 'type approval operations' in EF['AD']
..


Patch Set 5:

(1 comment)

Thanks_for_the_feedback

https://gerrit.osmocom.org/c/pysim/+/23632/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/pysim/+/23632/1//COMMIT_MSG@7
PS1, Line 7: S
> Do you think it is advisable for all SIM cards of all users to be programmed 
> for 'type approval' at  […]
Good question. The default value depends on the targeted group that uses this 
software. I was thinking of research and development here. The explicit request 
is the best option - full agreement. However, I wanted to be minimally invasive 
in my initial contributions and I didn't want to make offensive changes to the 
method signatures with possibly unexpected side effects.
(Apparently this single line change was already too much either. 
https://osmocom.org/issues/4383 Sorry for that.)

I'm happy to prepare a version with parameters, soon.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Falkenberg 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 05 Apr 2021 19:36:55 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment


Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-05 Thread Robert Falkenberg
Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/23632

to look at the new patch set (#5).

Change subject: Set uSIM to 'type approval operations' in EF['AD']
..

Set uSIM to 'type approval operations' in EF['AD']

The ``EF_AD`` field contains administrative data (AD).
It consists of four bytes ``B1``, ``B2``, ``B3``, ``B4``,
and optionally further bytes for future use.

Current implementation only sets the MNC field appropriately
(located in `B4`) and sets all other bits/bytes to 0.

However, `B1` defines the *UE operation mode* as listed below.
For type approval operations (such as testing with a test uSIM),
this value should be set to `0x80` rather than `0x00`(= normal operation).
This may unlock some UE capabilities that are restricted in
normal operation mode.

Excerpt from [ETSI TS 131 102, 
4.2.18](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf):

```
B1 - UE operation mode:
Coding:
Initial value
- '00' normal operation.
- '80' type approval operations.
- '01' normal operation + specific facilities.
- '81' type approval operations + specific facilities.
- '02' maintenance (off line).
- '04' cell test operation.

B2 - Additional information:
Coding:
Reserved for future use

B3 - Additional information:
Coding:
- B3.b1: OFM setting (Ciphering)
- B3.others: Reserved for future use

B4 - Length of MNC in the IMSI:
Coding:
- B4.b4..B4.b1: length:  '0010' (= 2) or '0011' (=3)
- B4.others: Reserved for future use
```

**Legend:** Byte X, bit Y: BX.bY

Further reading: https://nickvsnetworking.com/usim-basics/


Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
---
M pySim/cards.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/23632/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Falkenberg 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-05 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/23632 )

Change subject: Set uSIM to 'type approval operations' in EF['AD']
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23632/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/pysim/+/23632/1//COMMIT_MSG@7
PS1, Line 7: S
Do you think it is advisable for all SIM cards of all users to be programmed 
for 'type approval' at all times?  I think that is a flag which should only be 
set upon explicit request of the user, under certain circumstances.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Falkenberg 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 05 Apr 2021 11:50:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-05 Thread Robert Falkenberg
Robert Falkenberg has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/23632 )

Change subject: Set uSIM to 'type approval operations' in EF['AD']
..


Patch Set 1:

The ``EF_AD`` field contains administrative data (AD).
It consists of four bytes ``B1``, ``B2``, ``B3``, ``B4``, and optionally 
further bytes for future use.

Current implementation only sets the MNC field appropriately (located in `B4`) 
and sets all other bits/bytes to 0.

However, `B1` defines the *UE operation mode* as listed below. For type 
approval operations (such as testing with a test uSIM), this value should be 
set to `0x80` rather than `0x00`(= normal operation).
This may unlock some UE capabilities that are restricted in normal operation 
mode.

Excerpt from [ETSI TS 131 102, 
4.2.18](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf):

```
B1 - UE operation mode:
Coding:
Initial value
- '00' normal operation.
- '80' type approval operations.
- '01' normal operation + specific facilities.
- '81' type approval operations + specific facilities.
- '02' maintenance (off line).
- '04' cell test operation.

B2 - Additional information:
Coding:
Reserved for future use

B3 - Additional information:
Coding:
- B3.b1: OFM setting (Ciphering)
- B3.others: Reserved for future use

B4 - Length of MNC in the IMSI:
Coding:
- B4.b4..B4.b1: length:  '0010' (= 2) or '0011' (=3)
- B4.others: Reserved for future use
```

**Legend:** Byte X, bit Y: BX.bY

Further reading: https://nickvsnetworking.com/usim-basics/


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Falkenberg 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 05 Apr 2021 06:27:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-05 Thread Robert Falkenberg
Robert Falkenberg has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/23632 )


Change subject: Set uSIM to 'type approval operations' in EF['AD']
..

Set uSIM to 'type approval operations' in EF['AD']

Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
---
M pySim/cards.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/23632/1

diff --git a/pySim/cards.py b/pySim/cards.py
index 5eb2884..654d3fa 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -167,7 +167,7 @@
if data.lower() == "":
data = ""

-   content = data[0:6] + "%02X" % mnclen
+   content = "80" + data[2:6] + "%02X" % mnclen
data, sw = self._scc.update_binary(EF['AD'], content)
return sw


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Falkenberg 
Gerrit-MessageType: newchange