Change in pysim[master]: cards.py: unify card programming
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in pysim[master]: cards.py: unify card programming
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Patch Set 5: > Patch Set 5: > > ping? should we still get this mergd at some point? I think we should abandon this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 08 Apr 2021 13:18:24 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: cards.py: unify card programming
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Patch Set 5: ping? should we still get this mergd at some point? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 05 Apr 2021 11:47:56 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...pysim[master]: cards.py: unify card programming
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Patch Set 5: > I looked in cards.py now I am missing the following three: > > SysmoUSIMgr1 I should have those. Pleas remind me next week when I'm back to the office. > OpenCellsSim > FairwavesSIM it makes sense to ask the authors of the respective patches to send us some card samples, as we otherwise cannot maintain that card support in the tree. Please check the git log and contact the respective authors. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 24 Sep 2019 11:59:54 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...pysim[master]: cards.py: unify card programming
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Patch Set 5: > Patch Set 5: Code-Review+1 > > Looks fine to me. I can give you sysmoSIM-GR1, GR2 and magicSIM samples, but > I don't think I have other cards to test with. I already have those cards, I looked in cards.py now I am missing the following three: SysmoUSIMgr1 OpenCellsSim FairwavesSIM -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 24 Sep 2019 09:17:54 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...pysim[master]: cards.py: unify card programming
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Patch Set 5: Code-Review+1 Looks fine to me. I can give you sysmoSIM-GR1, GR2 and magicSIM samples, but I don't think I have other cards to test with. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 24 Sep 2019 07:44:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...pysim[master]: cards.py: unify card programming
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Patch Set 4: I have carried this out in the hope to clean up the code in cards.py a bit. This patch is intended to be an intermediate step towards a more object oriented idea. Unfortunately I can not really continue because I am missing card samples so I can not test. I don't know maybe this is helpful anyway, otherwise we also can abandon this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib757b1433c075c635fe43542103acae2167a1a15 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Mon, 23 Sep 2019 08:17:42 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
