Change in simtrace2[master]: LED: add need pattern
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/9923 Change subject: LED: add need pattern .. LED: add need pattern new LED pattern: off for 200 ms and then on Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c --- M firmware/libboard/common/include/led.h M firmware/libboard/common/source/led.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/23/9923/1 diff --git a/firmware/libboard/common/include/led.h b/firmware/libboard/common/include/led.h index 0c851f0..339702d 100644 --- a/firmware/libboard/common/include/led.h +++ b/firmware/libboard/common/include/led.h @@ -31,6 +31,7 @@ BLINK_200O_F= 7, BLINK_600O_F= 8, BLINK_CUSTOM= 9, + BLINK_2F_O, _NUM_LED_BLINK }; diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c index e3293b6..6772007 100644 --- a/firmware/libboard/common/source/led.c +++ b/firmware/libboard/common/source/led.c @@ -73,16 +73,23 @@ static const struct blink_state bs_3on_1off_3on_1off_3on_30off[] = { { 300, 1 }, { 100, 0 }, { 300, 1 }, { 100, 0 }, { 300, 1 }, { 3000, 0 } }; + static const struct blink_state bs_2on_off[] = { { 200, 1 }, { 0, 0 }, }; + static const struct blink_state bs_200on_off[] = { { 2, 1 }, { 0, 0 }, }; + static const struct blink_state bs_600on_off[] = { { 6, 1 }, { 0, 0 }, }; +static const struct blink_state bs_2off_on[] = { + { 200, 0 }, { 0, 1 }, +}; + /* a blink pattern is an array of blink_states */ struct blink_pattern { @@ -128,6 +135,11 @@ .states = bs_600on_off, .size = ARRAY_SIZE(bs_600on_off), }, + [BLINK_2F_O] = { + .states = bs_2off_on, + .size = ARRAY_SIZE(bs_2off_on), + }, + }; struct led_state { -- To view, visit https://gerrit.osmocom.org/9923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c Gerrit-Change-Number: 9923 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon
Change in simtrace2[master]: LED: add need pattern
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9923 to look at the new patch set (#5). Change subject: LED: add need pattern .. LED: add need pattern new LED pattern: off for 200 ms and then on Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c --- M firmware/libboard/common/include/led.h M firmware/libboard/common/source/led.c 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/23/9923/5 -- To view, visit https://gerrit.osmocom.org/9923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c Gerrit-Change-Number: 9923 Gerrit-PatchSet: 5 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Jenkins Builder
Change in simtrace2[master]: LED: add need pattern
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9923 ) Change subject: LED: add need pattern .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c Gerrit-Change-Number: 9923 Gerrit-PatchSet: 5 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 11 Jul 2018 19:54:54 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in simtrace2[master]: LED: add need pattern
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9923 ) Change subject: LED: add need pattern .. LED: add need pattern new LED pattern: off for 200 ms and then on Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c --- M firmware/libboard/common/include/led.h M firmware/libboard/common/source/led.c 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/firmware/libboard/common/include/led.h b/firmware/libboard/common/include/led.h index 0c851f0..339702d 100644 --- a/firmware/libboard/common/include/led.h +++ b/firmware/libboard/common/include/led.h @@ -31,6 +31,7 @@ BLINK_200O_F= 7, BLINK_600O_F= 8, BLINK_CUSTOM= 9, + BLINK_2F_O, _NUM_LED_BLINK }; diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c index e3293b6..6772007 100644 --- a/firmware/libboard/common/source/led.c +++ b/firmware/libboard/common/source/led.c @@ -73,16 +73,23 @@ static const struct blink_state bs_3on_1off_3on_1off_3on_30off[] = { { 300, 1 }, { 100, 0 }, { 300, 1 }, { 100, 0 }, { 300, 1 }, { 3000, 0 } }; + static const struct blink_state bs_2on_off[] = { { 200, 1 }, { 0, 0 }, }; + static const struct blink_state bs_200on_off[] = { { 2, 1 }, { 0, 0 }, }; + static const struct blink_state bs_600on_off[] = { { 6, 1 }, { 0, 0 }, }; +static const struct blink_state bs_2off_on[] = { + { 200, 0 }, { 0, 1 }, +}; + /* a blink pattern is an array of blink_states */ struct blink_pattern { @@ -128,6 +135,11 @@ .states = bs_600on_off, .size = ARRAY_SIZE(bs_600on_off), }, + [BLINK_2F_O] = { + .states = bs_2off_on, + .size = ARRAY_SIZE(bs_2off_on), + }, + }; struct led_state { -- To view, visit https://gerrit.osmocom.org/9923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id2c40dc20d75ed6f38b735164ad1eb2860dc480c Gerrit-Change-Number: 9923 Gerrit-PatchSet: 6 Gerrit-Owner: Kévin Redon Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder