Change in simtrace2[master]: Revert "add ISO 7816-3 library to remsim project"
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23635 ) Change subject: Revert "add ISO 7816-3 library to remsim project" .. Revert "add ISO 7816-3 library to remsim project" This reverts commit 4a58c08d671adc928fea9dc12018c26818f24d4e. The code replicates to a large extent what is already present in iso7816_fidi.c and I have serious doubts about the correctness of the computation in its iso7816_3_calculate_wt() function. Change-Id: I3f26da4e9aa8d7b0f4b4b7992269cf365a643ec7 --- M firmware/apps/cardem/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/apps/cardem/Makefile b/firmware/apps/cardem/Makefile index d5f68a5..75c43e8 100644 --- a/firmware/apps/cardem/Makefile +++ b/firmware/apps/cardem/Makefile @@ -1,3 +1,3 @@ C_FILES += $(C_LIBUSB_RT) -C_FILES += card_emu.c cciddriver.c iso7816_3.c iso7816_4.c iso7816_fidi.c mitm.c mode_cardemu.c mode_ccid.c simtrace_iso7816.c sniffer.c tc_etu.c usb.c +C_FILES += card_emu.c cciddriver.c iso7816_4.c iso7816_fidi.c mitm.c mode_cardemu.c mode_ccid.c simtrace_iso7816.c sniffer.c tc_etu.c usb.c -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3f26da4e9aa8d7b0f4b4b7992269cf365a643ec7 Gerrit-Change-Number: 23635 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in simtrace2[master]: Revert "add ISO 7816-3 library to remsim project"
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23635 ) Change subject: Revert "add ISO 7816-3 library to remsim project" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3f26da4e9aa8d7b0f4b4b7992269cf365a643ec7 Gerrit-Change-Number: 23635 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 06 Apr 2021 00:38:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: Revert "add ISO 7816-3 library to remsim project"
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/23635 ) Change subject: Revert "add ISO 7816-3 library to remsim project" .. Revert "add ISO 7816-3 library to remsim project" This reverts commit 4a58c08d671adc928fea9dc12018c26818f24d4e. The code replicates to a large extent what is already present in iso7816_fidi.c and I have serious doubts about the correctness of the computation in its iso7816_3_calculate_wt() function. Change-Id: I3f26da4e9aa8d7b0f4b4b7992269cf365a643ec7 --- M firmware/apps/cardem/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/35/23635/1 diff --git a/firmware/apps/cardem/Makefile b/firmware/apps/cardem/Makefile index d5f68a5..75c43e8 100644 --- a/firmware/apps/cardem/Makefile +++ b/firmware/apps/cardem/Makefile @@ -1,3 +1,3 @@ C_FILES += $(C_LIBUSB_RT) -C_FILES += card_emu.c cciddriver.c iso7816_3.c iso7816_4.c iso7816_fidi.c mitm.c mode_cardemu.c mode_ccid.c simtrace_iso7816.c sniffer.c tc_etu.c usb.c +C_FILES += card_emu.c cciddriver.c iso7816_4.c iso7816_fidi.c mitm.c mode_cardemu.c mode_ccid.c simtrace_iso7816.c sniffer.c tc_etu.c usb.c -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3f26da4e9aa8d7b0f4b4b7992269cf365a643ec7 Gerrit-Change-Number: 23635 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange
