Change in simtrace2[master]: card_emu: explicitly initialize PTS and TPDU states
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23642 ) Change subject: card_emu: explicitly initialize PTS and TPDU states .. card_emu: explicitly initialize PTS and TPDU states Those are already initialized at various transitions of the master 7816 FSM, but let's properly initialize them at start-up, too. Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df --- M firmware/libcommon/source/card_emu.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index 216ffe3..0ba6eb0 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -1264,6 +1264,9 @@ ch->atr.len = sizeof(default_atr); memcpy(ch->atr.atr, default_atr, ch->atr.len); + ch->pts.state = PTS_S_WAIT_REQ_PTSS; + ch->tpdu.state = TPDU_S_WAIT_CLA; + card_handle_reset(ch); tc_etu_init(ch->tc_chan, ch); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df Gerrit-Change-Number: 23642 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: merged
Change in simtrace2[master]: card_emu: explicitly initialize PTS and TPDU states
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23642 ) Change subject: card_emu: explicitly initialize PTS and TPDU states .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df Gerrit-Change-Number: 23642 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Thu, 08 Apr 2021 21:28:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: card_emu: explicitly initialize PTS and TPDU states
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23642 to look at the new patch set (#2). Change subject: card_emu: explicitly initialize PTS and TPDU states .. card_emu: explicitly initialize PTS and TPDU states Those are already initialized at various transitions of the master 7816 FSM, but let's properly initialize them at start-up, too. Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df --- M firmware/libcommon/source/card_emu.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/42/23642/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df Gerrit-Change-Number: 23642 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in simtrace2[master]: card_emu: explicitly initialize PTS and TPDU states
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/23642 ) Change subject: card_emu: explicitly initialize PTS and TPDU states .. card_emu: explicitly initialize PTS and TPDU states Those are already initialized at various transitions of the master 7816 FSM, but let's properly initialize them at start-up, too. Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df --- M firmware/libcommon/source/card_emu.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/42/23642/1 diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index 216ffe3..0ba6eb0 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -1264,6 +1264,9 @@ ch->atr.len = sizeof(default_atr); memcpy(ch->atr.atr, default_atr, ch->atr.len); + ch->pts.state = PTS_S_WAIT_REQ_PTSS; + ch->tpdu.state = TPDU_S_WAIT_CLA; + card_handle_reset(ch); tc_etu_init(ch->tc_chan, ch); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I81b2a8ef3284559164700d94717e4ccf008f53df Gerrit-Change-Number: 23642 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-CC: Jenkins Builder Gerrit-MessageType: newchange
